From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 2/2] gfs2: change gfs2 readdir cookie
Date: Tue, 1 Dec 2015 10:01:41 -0500 (EST) [thread overview]
Message-ID: <743931970.23064200.1448982101254.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1448950218-10399-3-git-send-email-bmarzins@redhat.com>
Hi Ben,
----- Original Message -----
(snip)
> diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h
> index 921304e..e8eaf71 100644
> --- a/fs/gfs2/incore.h
> +++ b/fs/gfs2/incore.h
> @@ -562,6 +562,8 @@ struct gfs2_args {
> unsigned int ar_errors:2; /* errors=withdraw | panic */
> unsigned int ar_nobarrier:1; /* do not send barriers */
> unsigned int ar_rgrplvb:1; /* use lvbs for rgrp info */
> + unsigned int ar_loccookie; /* use location based readdir
> + cookies */
> int ar_commit; /* Commit interval */
> int ar_statfs_quantum; /* The fast statfs interval */
> int ar_quota_quantum; /* The quota interval */
Just a nit: Is okay if we specify ar_loccookie:1 for consistency?
Otherwise, the patches look good, and I've tested a RHEL6 port of them
using specsfs which uses NFS and gives this code a good workout.
Regards,
Bob Peterson
Red Hat File Systems
next prev parent reply other threads:[~2015-12-01 15:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 6:10 [Cluster-devel] [PATCH 0/2] positional readdir cookies Benjamin Marzinski
2015-12-01 6:10 ` [Cluster-devel] [PATCH 1/2] gfs2: keep offset when splitting dir leaf blocks Benjamin Marzinski
2015-12-01 6:10 ` [Cluster-devel] [PATCH 2/2] gfs2: change gfs2 readdir cookie Benjamin Marzinski
2015-12-01 15:01 ` Bob Peterson [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-07-18 4:40 [Cluster-devel] [PATCH 0/2] readdir cookie patches Benjamin Marzinski
2015-07-18 4:40 ` [Cluster-devel] [PATCH 2/2] gfs2: change gfs2 readdir cookie Benjamin Marzinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=743931970.23064200.1448982101254.JavaMail.zimbra@redhat.com \
--to=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).