From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bob Peterson <rpeterso@redhat.com>
Date: Tue, 1 Dec 2015 10:01:41 -0500 (EST)
Subject: [Cluster-devel] [PATCH 2/2] gfs2: change gfs2 readdir cookie
In-Reply-To: <1448950218-10399-3-git-send-email-bmarzins@redhat.com>
References: <1448950218-10399-1-git-send-email-bmarzins@redhat.com>
	<1448950218-10399-3-git-send-email-bmarzins@redhat.com>
Message-ID: <743931970.23064200.1448982101254.JavaMail.zimbra@redhat.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Hi Ben,

----- Original Message -----
(snip)

> diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h
> index 921304e..e8eaf71 100644
> --- a/fs/gfs2/incore.h
> +++ b/fs/gfs2/incore.h
> @@ -562,6 +562,8 @@ struct gfs2_args {
>  	unsigned int ar_errors:2;               /* errors=withdraw | panic */
>  	unsigned int ar_nobarrier:1;            /* do not send barriers */
>  	unsigned int ar_rgrplvb:1;		/* use lvbs for rgrp info */
> +	unsigned int ar_loccookie;		/* use location based readdir
> +						   cookies */
>  	int ar_commit;				/* Commit interval */
>  	int ar_statfs_quantum;			/* The fast statfs interval */
>  	int ar_quota_quantum;			/* The quota interval */

Just a nit: Is okay if we specify ar_loccookie:1 for consistency?

Otherwise, the patches look good, and I've tested a RHEL6 port of them
using specsfs which uses NFS and gives this code a good workout.

Regards,

Bob Peterson
Red Hat File Systems