cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 2/4] mkfs.gfs2: Align resource groups to RAID stripes
Date: Thu, 6 Jun 2013 09:30:38 -0400 (EDT)	[thread overview]
Message-ID: <801643481.48150826.1370525438027.JavaMail.root@redhat.com> (raw)
In-Reply-To: <1370524289.2744.23.camel@menhir>

----- Original Message -----
| It has never been valid to assume that all the rgrps are the same size.

Well, as I said: due to gfs2_convert, we can't enforce it. However,
gfs2_grow and fsck.gfs2 were originally designed under that assumption.
Today's gfs2_grow may still be assuming it, which might be wrong, and
perhaps should be investigated. (It's been too long since I've looked at it.)
My concern here is that gfs2_grow operates properly on a gfs2_converted
file system from gfs1 with non-uniform rgrps, especially if the Nth rgrp
and N-1th rgrp are different sizes; could damage result? Worth checking.

|  - Would it be useful to introduce a flag to show the source of an rgrp
| (whether mkfs or gfs2_grow) ?

Yes, good idea.

|  - Would it be useful to add a creation date stamp to each rgrp so that
| we can see when things have happened in the past?

Another good idea.

Bob



  reply	other threads:[~2013-06-06 13:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-06 12:03 [Cluster-devel] [PATCH 1/4] mkfs.gfs2: Set sunit and swidth from probed io limits Andrew Price
2013-06-06 12:03 ` [Cluster-devel] [PATCH 2/4] mkfs.gfs2: Align resource groups to RAID stripes Andrew Price
2013-06-06 12:06   ` Steven Whitehouse
2013-06-06 12:19     ` Andrew Price
2013-06-06 12:57   ` Bob Peterson
2013-06-06 13:04     ` Andrew Price
2013-06-06 13:17       ` Bob Peterson
2013-06-06 13:11     ` Steven Whitehouse
2013-06-06 13:30       ` Bob Peterson [this message]
2013-06-06 15:17       ` Andrew Price
2013-06-06 12:03 ` [Cluster-devel] [PATCH 3/4] mkfs.gfs2: Create new resource groups on-demand Andrew Price
2013-06-06 13:07   ` Bob Peterson
2013-06-06 13:50     ` Andrew Price
2013-06-06 12:03 ` [Cluster-devel] [PATCH 4/4] mkfs.gfs2: Add align option and update docs Andrew Price
2013-06-06 12:15   ` Steven Whitehouse
2013-06-06 12:45     ` Andrew Price
2013-06-06 12:53       ` Steven Whitehouse
2013-06-06 13:13   ` Bob Peterson
2013-06-06 13:53     ` Andrew Price

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=801643481.48150826.1370525438027.JavaMail.root@redhat.com \
    --to=rpeterso@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).