* [Cluster-devel] [GFS2 PATCH] GFS2: Allow caching of glocks for flock
[not found] <2059474056.3713060.1403785334209.JavaMail.zimbra@redhat.com>
@ 2014-06-26 12:23 ` Bob Peterson
0 siblings, 0 replies; 2+ messages in thread
From: Bob Peterson @ 2014-06-26 12:23 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
This patch removes the GLF_NOCACHE flag from the glocks associated with
flocks. There should be no good reason not to cache glocks for flocks:
they only force the glock to be demoted before they can be reacquired,
which can slow down performance and even cause glock hangs, especially
in cases where the flocks are held in Shared (SH) mode.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
---
diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c
index 4fc3a30..0740a57 100644
--- a/fs/gfs2/file.c
+++ b/fs/gfs2/file.c
@@ -981,7 +981,7 @@ static int do_flock(struct file *file, int cmd, struct file_lock *fl)
int error = 0;
state = (fl->fl_type == F_WRLCK) ? LM_ST_EXCLUSIVE : LM_ST_SHARED;
- flags = (IS_SETLKW(cmd) ? 0 : LM_FLAG_TRY) | GL_EXACT | GL_NOCACHE;
+ flags = (IS_SETLKW(cmd) ? 0 : LM_FLAG_TRY) | GL_EXACT;
mutex_lock(&fp->f_fl_mutex);
^ permalink raw reply related [flat|nested] 2+ messages in thread
[parent not found: <1363072721.3808531.1403794014002.JavaMail.zimbra@redhat.com>]
* [Cluster-devel] [GFS2 PATCH] GFS2: Allow caching of glocks for flock
[not found] <1363072721.3808531.1403794014002.JavaMail.zimbra@redhat.com>
@ 2014-06-26 14:47 ` Bob Peterson
0 siblings, 0 replies; 2+ messages in thread
From: Bob Peterson @ 2014-06-26 14:47 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
This patch removes the GLF_NOCACHE flag from the glocks associated with
flocks. There should be no good reason not to cache glocks for flocks:
they only force the glock to be demoted before they can be reacquired,
which can slow down performance and even cause glock hangs, especially
in cases where the flocks are held in Shared (SH) mode.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
---
diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c
index 4fc3a30..0740a57 100644
--- a/fs/gfs2/file.c
+++ b/fs/gfs2/file.c
@@ -981,7 +981,7 @@ static int do_flock(struct file *file, int cmd, struct file_lock *fl)
int error = 0;
state = (fl->fl_type == F_WRLCK) ? LM_ST_EXCLUSIVE : LM_ST_SHARED;
- flags = (IS_SETLKW(cmd) ? 0 : LM_FLAG_TRY) | GL_EXACT | GL_NOCACHE;
+ flags = (IS_SETLKW(cmd) ? 0 : LM_FLAG_TRY) | GL_EXACT;
mutex_lock(&fp->f_fl_mutex);
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-26 14:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <2059474056.3713060.1403785334209.JavaMail.zimbra@redhat.com>
2014-06-26 12:23 ` [Cluster-devel] [GFS2 PATCH] GFS2: Allow caching of glocks for flock Bob Peterson
[not found] <1363072721.3808531.1403794014002.JavaMail.zimbra@redhat.com>
2014-06-26 14:47 ` Bob Peterson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).