From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Thu, 31 Aug 2017 09:11:26 -0400 (EDT) Subject: [Cluster-devel] [PATCH 1/2] gfs2: don't return ENODATA in __gfs2_xattr_set unless replacing In-Reply-To: References: Message-ID: <85277283.4008685.1504185086884.JavaMail.zimbra@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit ----- Original Message ----- | The function __gfs2_xattr_set() will return -ENODATA when called to | remove a xattr that does not exist. The result is that setfacl will | show an exit status of 1 when called to set only a file's mode bits | (on a file with no ACLs), despite succeeding. A "No data available" | error will be printed as well. | | To fix this return 0 instead, except when the XATTR_REPLACE flag is | set, in which case -ENODATA is appropriate. This is consistent with | how most other xattr setting functions work, in other filesystems. | | Signed-off-by: Ernesto A. Fern?ndez | --- Hi, Thanks. This is now pushed to the for-next branch of the linux-gfs2 tree: https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=54aae14beee6a6e9f72358f1873b3e497029c41d Regards, Bob Peterson Red Hat File Systems