From: Jim Meyering <jim@meyering.net>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH dlm] fix compile failures
Date: Fri, 26 Jun 2009 09:39:01 +0200 [thread overview]
Message-ID: <87prcr8mwa.fsf@meyering.net> (raw)
dlm.git (master) did not build:
dlmtest2.c: In function ?main?:
dlmtest2.c:1418: warning: the address of ?cmd? will always evaluate as ?true?
dlmtest2.c:1420: error: label ?out? used but not defined
With these changes, it does:
From cdda56dcbb999b3ffd6dd080fa97f8dd8eefcc14 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Fri, 26 Jun 2009 09:34:49 +0200
Subject: [PATCH dlm] fix compile failures
* dlm/tests/usertest/dlmtest2.c:
(main): Restore accidentally removed label. It's still used.
(main): Test "opt_cmd", rather than the always-true array, "cmd".
---
dlm/tests/usertest/dlmtest2.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/dlm/tests/usertest/dlmtest2.c b/dlm/tests/usertest/dlmtest2.c
index 6160d4a..9d3afd9 100644
--- a/dlm/tests/usertest/dlmtest2.c
+++ b/dlm/tests/usertest/dlmtest2.c
@@ -120,7 +120,7 @@ static void unlockf(int i);
static int rand_int(int a, int b)
{
- return a + (int) (((float)(b - a + 1)) * random() / (RAND_MAX+1.0));
+ return a + (int) (((float)(b - a + 1)) * random() / (RAND_MAX+1.0));
}
static const char *status_str(int status)
@@ -1415,7 +1415,7 @@ int main(int argc, char *argv[])
client_add(libdlm_fd, &maxi);
- if (cmd) {
+ if (opt_cmd) {
process_command(&quit);
goto out;
}
@@ -1450,6 +1450,7 @@ int main(int argc, char *argv[])
break;
}
+ out:
if (openclose_ls) {
printf("dlm_close_lockspace\n");
@@ -1466,4 +1467,3 @@ int main(int argc, char *argv[])
return 0;
}
-
--
1.6.3.3.420.gd4b46
reply other threads:[~2009-06-26 7:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87prcr8mwa.fsf@meyering.net \
--to=jim@meyering.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox