From: Damien Le Moal <dlemoal@kernel.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 08/13] iomap: assign current->backing_dev_info in iomap_file_buffered_write
Date: Mon, 22 May 2023 09:05:00 +0900 [thread overview]
Message-ID: <88fe9652-3cf5-c601-08f1-64b75e367ca5@kernel.org> (raw)
In-Reply-To: <20230519093521.133226-9-hch@lst.de>
On 5/19/23 18:35, Christoph Hellwig wrote:
> Move the assignment to current->backing_dev_info from the callers into
> iomap_file_buffered_write to reduce boiler plate code and reduce the
> scope to just around the page dirtying loop.
>
> Note that zonefs was missing this assignment before.
Hu... Shouldn't this be fixed as a separate patch with a Fixes tag for this cycle ?
I have never noticed any issues with this missing though. Not sure how an issue
can be triggered with this assignment missing.
Apart from that, this patch look good to me.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2023-05-22 0:05 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 9:35 [Cluster-devel] cleanup the filemap / direct I/O interaction Christoph Hellwig
2023-05-19 9:35 ` [Cluster-devel] [PATCH 01/13] iomap: update ki_pos a little later in iomap_dio_complete Christoph Hellwig
2023-05-21 23:40 ` Damien Le Moal
2023-07-06 0:18 ` [Cluster-devel] [f2fs-dev] " patchwork-bot+f2fs
2023-05-19 9:35 ` [Cluster-devel] [PATCH 02/13] filemap: update ki_pos in generic_perform_write Christoph Hellwig
2023-05-21 23:42 ` Damien Le Moal
2023-05-22 2:20 ` Xiubo Li
2023-05-19 9:35 ` [Cluster-devel] [PATCH 03/13] filemap: assign current->backing_dev_info " Christoph Hellwig
2023-05-21 23:44 ` Damien Le Moal
2023-05-22 2:22 ` Xiubo Li
2023-05-19 9:35 ` [Cluster-devel] [PATCH 04/13] filemap: add a kiocb_write_and_wait helper Christoph Hellwig
2023-05-21 23:46 ` Damien Le Moal
2023-05-19 9:35 ` [Cluster-devel] [PATCH 05/13] filemap: add a kiocb_invalidate_pages helper Christoph Hellwig
2023-05-21 23:51 ` Damien Le Moal
2023-05-19 9:35 ` [Cluster-devel] [PATCH 06/13] filemap: add a kiocb_invalidate_post_write helper Christoph Hellwig
2023-05-21 23:56 ` Damien Le Moal
2023-05-23 16:01 ` Christoph Hellwig
2023-05-19 9:35 ` [Cluster-devel] [PATCH 07/13] iomap: update ki_pos in iomap_file_buffered_write Christoph Hellwig
2023-05-22 0:01 ` Damien Le Moal
2023-05-23 16:02 ` Christoph Hellwig
2023-05-19 9:35 ` [Cluster-devel] [PATCH 08/13] iomap: assign current->backing_dev_info " Christoph Hellwig
2023-05-22 0:05 ` Damien Le Moal [this message]
2023-05-23 1:06 ` Darrick J. Wong
2023-05-23 3:30 ` Matthew Wilcox
2023-05-23 16:02 ` Christoph Hellwig
2023-05-19 9:35 ` [Cluster-devel] [PATCH 09/13] iomap: use kiocb_write_and_wait and kiocb_invalidate_pages Christoph Hellwig
2023-05-22 0:07 ` Damien Le Moal
2023-05-19 9:35 ` [Cluster-devel] [PATCH 10/13] fs: factor out a direct_write_fallback helper Christoph Hellwig
2023-05-22 0:16 ` Damien Le Moal
2023-05-22 14:19 ` Miklos Szeredi
2023-05-23 16:03 ` Christoph Hellwig
2023-05-19 9:35 ` [Cluster-devel] [PATCH 11/13] fuse: update ki_pos in fuse_perform_write Christoph Hellwig
2023-05-22 0:18 ` Damien Le Moal
2023-05-19 9:35 ` [Cluster-devel] [PATCH 12/13] fuse: drop redundant arguments to fuse_perform_write Christoph Hellwig
2023-05-22 0:19 ` Damien Le Moal
2023-05-19 9:35 ` [Cluster-devel] [PATCH 13/13] fuse: use direct_write_fallback Christoph Hellwig
2023-05-22 0:20 ` Damien Le Moal
2023-05-23 1:12 ` [Cluster-devel] cleanup the filemap / direct I/O interaction Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88fe9652-3cf5-c601-08f1-64b75e367ca5@kernel.org \
--to=dlemoal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).