From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [GFS2 PATCH] GFS2: Simplify iterative add loop in foreach_descriptor
Date: Thu, 9 Aug 2018 08:15:28 -0400 (EDT) [thread overview]
Message-ID: <894674386.961151.1533816928583.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <2e040139-cc86-3256-884e-8e52e48e6df7@redhat.com>
----- Original Message -----
> Now you've hidden the increment of the replay block. Please don't open
> code this, but just add an argument to gfs2_replay_incr_blk() such that
> you can tell it how many blocks to increment, rather than just assuming
> a single block as it does at the moment. Otherwise this can easily get
> missed when someone looks at the code in future, and expects
> gfs2_replay_incr_blk to be the only thing that changes the position
> during recovery,
>
> Steve.
Hi,
Since we're so close to the merge window, I'll just remove it from the tree
and do this afterward.
Bob Peterson
next prev parent reply other threads:[~2018-08-09 12:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <17883672.769837.1533754253446.JavaMail.zimbra@redhat.com>
2018-08-08 18:52 ` [Cluster-devel] [GFS2 PATCH] GFS2: Simplify iterative add loop in foreach_descriptor Bob Peterson
2018-08-08 19:21 ` Andreas Gruenbacher
2018-08-08 21:59 ` Abhijith Das
2018-08-09 9:35 ` Steven Whitehouse
2018-08-09 12:15 ` Bob Peterson [this message]
2018-08-10 12:13 ` Andreas Gruenbacher
2018-08-10 12:21 ` Steven Whitehouse
2018-08-10 14:26 ` Abhijith Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=894674386.961151.1533816928583.JavaMail.zimbra@redhat.com \
--to=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).