From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bob Peterson <rpeterso@redhat.com>
Date: Thu, 9 Aug 2018 08:15:28 -0400 (EDT)
Subject: [Cluster-devel] [GFS2 PATCH] GFS2: Simplify iterative add loop
 in foreach_descriptor
In-Reply-To: <2e040139-cc86-3256-884e-8e52e48e6df7@redhat.com>
References: <183182471.770089.1533754323408.JavaMail.zimbra@redhat.com>
	<2e040139-cc86-3256-884e-8e52e48e6df7@redhat.com>
Message-ID: <894674386.961151.1533816928583.JavaMail.zimbra@redhat.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

----- Original Message -----
> Now you've hidden the increment of the replay block. Please don't open
> code this, but just add an argument to gfs2_replay_incr_blk() such that
> you can tell it how many blocks to increment, rather than just assuming
> a single block as it does at the moment. Otherwise this can easily get
> missed when someone looks at the code in future, and expects
> gfs2_replay_incr_blk to be the only thing that changes the position
> during recovery,
> 
> Steve.

Hi,

Since we're so close to the merge window, I'll just remove it from the tree
and do this afterward.

Bob Peterson