[Cluster-devel] [GFS2 PATCH 13/15] gfs2: ignore usr|grp|prjquota mount options

[Andrew Price <anprice@redhat.com>]

On 28/07/2021 21:32, Bob Peterson wrote:
> On 7/28/21 1:28 PM, Andreas Gruenbacher wrote:
>> On Tue, Jul 27, 2021 at 7:37 PM Bob Peterson <rpeterso@redhat.com> wrote:
>>> Before this patch, gfs2 rejected mounts attempted with the usrquota,
>>> grpquota, or prjquota mount options. That caused numerous xfstests tests
>>> to fail. This patch allows gfs2 to accept but ignore those mount options
>>> so the tests may be run.
>>
>> We can't just fake this up. Instead, the fstests need to be fixed to
>> skip tests that don't run on particular filesystems.
> Hi Andreas,
> 
> I see your point, and sure, the maintainers of xfstests can improve the 
> tests to make them check whether the options are supported for gfs2 as
> they do with other some other options.
> 
> Still, if you look at the man page for "mount(8)" under "Mount options 
> for affs" you see:
> 
> "grpquota|noquota|quota|usrquota
> These options are accepted but ignored.? (However, quota utilities may 
> react to such strings in /etc/fstab.)"
> 
> If you look at "Mount options for jfs" you similarly see:
> 
> "noquota|quota|usrquota|grpquota
> These options are accepted but ignored."
> 
> So if affs and jfs can ignore these mount options, why can't gfs2?
> Are we planning to support them ever?
FWIW I agree with Andreas, this is definitely a bug in the test suite. 
If we fix fstests then we can use fstests for bisecting older gfs2 
issues, but if we no-op incompatible mount options that make their way 
into the generic tests then we're only fixing the tests for future gfs2 
versions and not older ones.

Andy