From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Price Date: Mon, 2 Aug 2021 09:46:03 +0100 Subject: [Cluster-devel] [GFS2 PATCH 13/15] gfs2: ignore usr|grp|prjquota mount options In-Reply-To: <0d471fd4-05e7-8b8b-6bbb-55a7cd2e72a2@redhat.com> References: <20210727173709.210711-1-rpeterso@redhat.com> <20210727173709.210711-14-rpeterso@redhat.com> <0d471fd4-05e7-8b8b-6bbb-55a7cd2e72a2@redhat.com> Message-ID: <93c92609-33a8-c9b9-a750-0bfbd6d8a882@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 28/07/2021 21:32, Bob Peterson wrote: > On 7/28/21 1:28 PM, Andreas Gruenbacher wrote: >> On Tue, Jul 27, 2021 at 7:37 PM Bob Peterson wrote: >>> Before this patch, gfs2 rejected mounts attempted with the usrquota, >>> grpquota, or prjquota mount options. That caused numerous xfstests tests >>> to fail. This patch allows gfs2 to accept but ignore those mount options >>> so the tests may be run. >> >> We can't just fake this up. Instead, the fstests need to be fixed to >> skip tests that don't run on particular filesystems. > Hi Andreas, > > I see your point, and sure, the maintainers of xfstests can improve the > tests to make them check whether the options are supported for gfs2 as > they do with other some other options. > > Still, if you look at the man page for "mount(8)" under "Mount options > for affs" you see: > > "grpquota|noquota|quota|usrquota > These options are accepted but ignored.? (However, quota utilities may > react to such strings in /etc/fstab.)" > > If you look at "Mount options for jfs" you similarly see: > > "noquota|quota|usrquota|grpquota > These options are accepted but ignored." > > So if affs and jfs can ignore these mount options, why can't gfs2? > Are we planning to support them ever? FWIW I agree with Andreas, this is definitely a bug in the test suite. If we fix fstests then we can use fstests for bisecting older gfs2 issues, but if we no-op incompatible mount options that make their way into the generic tests then we're only fixing the tests for future gfs2 versions and not older ones. Andy