* [Cluster-devel] [Patch 13/44] dirent_repair needs to mark the buffer as modified
@ 2011-08-11 21:03 Bob Peterson
2011-08-12 9:26 ` Steven Whitehouse
0 siblings, 1 reply; 2+ messages in thread
From: Bob Peterson @ 2011-08-11 21:03 UTC (permalink / raw)
To: cluster-devel.redhat.com
From fa744b806ad8655c9ed3a18fcbec1c7992735be5 Mon Sep 17 00:00:00 2001
From: Bob Peterson <rpeterso@redhat.com>
Date: Mon, 8 Aug 2011 14:47:49 -0500
Subject: [PATCH 13/44] dirent_repair needs to mark the buffer as modified
This patch adds a call to bmodified to function dirent_repair. Without
setting the modified bit, directory repairs may be forgotten and never
written back to disk, leaving the damage in place.
rhbz#675723
---
gfs2/fsck/metawalk.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/gfs2/fsck/metawalk.c b/gfs2/fsck/metawalk.c
index a4d7d3e..6bdea5a 100644
--- a/gfs2/fsck/metawalk.c
+++ b/gfs2/fsck/metawalk.c
@@ -266,6 +266,7 @@ static int dirent_repair(struct gfs2_inode *ip, struct gfs2_buffer_head *bh,
de->de_rec_len = GFS2_DIRENT_SIZE(de->de_name_len);
}
gfs2_dirent_out(de, (char *)dent);
+ bmodified(bh);
return 0;
}
--
1.7.4.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Cluster-devel] [Patch 13/44] dirent_repair needs to mark the buffer as modified
2011-08-11 21:03 [Cluster-devel] [Patch 13/44] dirent_repair needs to mark the buffer as modified Bob Peterson
@ 2011-08-12 9:26 ` Steven Whitehouse
0 siblings, 0 replies; 2+ messages in thread
From: Steven Whitehouse @ 2011-08-12 9:26 UTC (permalink / raw)
To: cluster-devel.redhat.com
Ack,
Steve.
On Thu, 2011-08-11 at 17:03 -0400, Bob Peterson wrote:
> >From fa744b806ad8655c9ed3a18fcbec1c7992735be5 Mon Sep 17 00:00:00 2001
> From: Bob Peterson <rpeterso@redhat.com>
> Date: Mon, 8 Aug 2011 14:47:49 -0500
> Subject: [PATCH 13/44] dirent_repair needs to mark the buffer as modified
>
> This patch adds a call to bmodified to function dirent_repair. Without
> setting the modified bit, directory repairs may be forgotten and never
> written back to disk, leaving the damage in place.
>
> rhbz#675723
> ---
> gfs2/fsck/metawalk.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/gfs2/fsck/metawalk.c b/gfs2/fsck/metawalk.c
> index a4d7d3e..6bdea5a 100644
> --- a/gfs2/fsck/metawalk.c
> +++ b/gfs2/fsck/metawalk.c
> @@ -266,6 +266,7 @@ static int dirent_repair(struct gfs2_inode *ip, struct gfs2_buffer_head *bh,
> de->de_rec_len = GFS2_DIRENT_SIZE(de->de_name_len);
> }
> gfs2_dirent_out(de, (char *)dent);
> + bmodified(bh);
> return 0;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-12 9:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-11 21:03 [Cluster-devel] [Patch 13/44] dirent_repair needs to mark the buffer as modified Bob Peterson
2011-08-12 9:26 ` Steven Whitehouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).