cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 09/10] dlm: Improve a size determination in two functions
Date: Sat, 6 May 2017 10:47:10 +0200	[thread overview]
Message-ID: <96e43ba3-1e9e-b598-f980-59751a720cc2@users.sourceforge.net> (raw)
In-Reply-To: <4bd895d7-9448-928d-1e4c-42326ce20607@users.sourceforge.net>

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 6 May 2017 09:45:59 +0200

Replace the specification of two data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 fs/dlm/member.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/dlm/member.c b/fs/dlm/member.c
index 92c601a11e38..3e565034ff2e 100644
--- a/fs/dlm/member.c
+++ b/fs/dlm/member.c
@@ -318,7 +318,7 @@ static int dlm_add_member(struct dlm_ls *ls, struct dlm_config_node *node)
 	struct dlm_member *memb;
 	int error;
 
-	memb = kzalloc(sizeof(struct dlm_member), GFP_NOFS);
+	memb = kzalloc(sizeof(*memb), GFP_NOFS);
 	if (!memb)
 		return -ENOMEM;
 
@@ -674,7 +674,7 @@ int dlm_ls_start(struct dlm_ls *ls)
 	struct dlm_config_node *nodes;
 	int error, count;
 
-	rv = kzalloc(sizeof(struct dlm_recover), GFP_NOFS);
+	rv = kzalloc(sizeof(*rv), GFP_NOFS);
 	if (!rv)
 		return -ENOMEM;
 
-- 
2.12.2



  parent reply	other threads:[~2017-05-06  8:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-06  8:34 [Cluster-devel] [PATCH 00/10] fs-DLM: Fine-tuning for several function implementations SF Markus Elfring
2017-05-06  8:36 ` [Cluster-devel] [PATCH 01/10] dlm: Replace six seq_puts() calls by seq_putc() SF Markus Elfring
2017-05-06  8:38 ` [Cluster-devel] [PATCH 02/10] dlm: Add spaces for better code readability SF Markus Elfring
2017-05-06  8:39 ` [Cluster-devel] [PATCH 03/10] dlm: Improve a size determination in table_seq_start() SF Markus Elfring
2017-05-06  8:40 ` [Cluster-devel] [PATCH 04/10] dlm: Use kcalloc() in dlm_scan_waiters() SF Markus Elfring
2017-05-06  8:41 ` [Cluster-devel] [PATCH 05/10] dlm: Improve a size determination in dlm_recover_waiters_pre() SF Markus Elfring
2017-05-06  8:43 ` [Cluster-devel] [PATCH 06/10] dlm: Delete an error message for a failed memory allocation " SF Markus Elfring
2017-05-06  8:44 ` [Cluster-devel] [PATCH 07/10] dlm: Use kmalloc_array() in make_member_array() SF Markus Elfring
2017-05-06  8:45 ` [Cluster-devel] [PATCH 08/10] dlm: Use kcalloc() in two functions SF Markus Elfring
2017-05-06  8:47 ` SF Markus Elfring [this message]
2017-05-06  8:48 ` [Cluster-devel] [PATCH 10/10] dlm: Delete an unnecessary variable initialisation in dlm_ls_start() SF Markus Elfring
2017-05-08 20:08 ` [Cluster-devel] [PATCH 00/10] fs-DLM: Fine-tuning for several function implementations Bob Peterson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96e43ba3-1e9e-b598-f980-59751a720cc2@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).