From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] gfs2: Get rid of gfs2_ea_strlen
Date: Fri, 3 Aug 2018 08:11:43 -0400 (EDT) [thread overview]
Message-ID: <973679608.57087837.1533298303474.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20180803112954.7274-1-agruenba@redhat.com>
Hi,
----- Original Message -----
> Function gfs2_ea_strlen is only called from ea_list_i, so inline it
> there. Remove the duplicate switch statement and the creative use of
> memcpy to set a null byte.
>
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
> ---
Definitely an improvement.
Reviewed-by: Bob Peterson <rpeterso@redhat.com>
Bob Peterson
prev parent reply other threads:[~2018-08-03 12:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 11:29 [Cluster-devel] [PATCH] gfs2: Get rid of gfs2_ea_strlen Andreas Gruenbacher
2018-08-03 11:45 ` Andrew Price
2018-08-03 12:11 ` Bob Peterson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=973679608.57087837.1533298303474.JavaMail.zimbra@redhat.com \
--to=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).