From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Fri, 3 Aug 2018 08:11:43 -0400 (EDT) Subject: [Cluster-devel] [PATCH] gfs2: Get rid of gfs2_ea_strlen In-Reply-To: <20180803112954.7274-1-agruenba@redhat.com> References: <20180803112954.7274-1-agruenba@redhat.com> Message-ID: <973679608.57087837.1533298303474.JavaMail.zimbra@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi, ----- Original Message ----- > Function gfs2_ea_strlen is only called from ea_list_i, so inline it > there. Remove the duplicate switch statement and the creative use of > memcpy to set a null byte. > > Signed-off-by: Andreas Gruenbacher > --- Definitely an improvement. Reviewed-by: Bob Peterson Bob Peterson