cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Andreas Gruenbacher <agruenba@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v1] gfs2: increase usage of folio_next_index() helper
Date: Mon, 17 Jul 2023 09:42:23 +0200	[thread overview]
Message-ID: <CAHc6FU4_SDSpom3Qvt35AXOmmc3v9EJYksgP4EN3owMEC2y-AA@mail.gmail.com> (raw)
In-Reply-To: <20230717071938.6204-1-duminjie@vivo.com>

Minjie,

On Mon, Jul 17, 2023 at 9:20?AM Minjie Du <duminjie@vivo.com> wrote:
> Simplify code pattern of 'folio->index + folio_nr_pages(folio)' by using
> the existing helper folio_next_index().
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
>  fs/gfs2/aops.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c
> index ae49256b7..5f0254237 100644
> --- a/fs/gfs2/aops.c
> +++ b/fs/gfs2/aops.c
> @@ -272,8 +272,7 @@ static int gfs2_write_jdata_batch(struct address_space *mapping,
>                                  * not be suitable for data integrity
>                                  * writeout).
>                                  */
> -                               *done_index = folio->index +
> -                                       folio_nr_pages(folio);
> +                               *done_index = folio_next_index(folio);
>                                 ret = 1;
>                                 break;
>                         }
> --
> 2.39.0
>

Applied, thanks.

Email addresses like '"open list:GFS2 FILE SYSTEM"
<cluster-devel@redhat.com>' and 'open list
<linux-kernel@vger.kernel.org>' are not helpful though, so could you
please avoid using addresses like that in the future?

Thanks,
Andreas


  reply	other threads:[~2023-07-17  7:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-17  7:19 [Cluster-devel] [PATCH v1] gfs2: increase usage of folio_next_index() helper Minjie Du
2023-07-17  7:42 ` Andreas Gruenbacher [this message]
2023-07-17  7:48   ` [Cluster-devel] 回复: " 杜敏杰

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHc6FU4_SDSpom3Qvt35AXOmmc3v9EJYksgP4EN3owMEC2y-AA@mail.gmail.com \
    --to=agruenba@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).