[Cluster-devel] [PATCH v1] gfs2: increase usage of folio_next_index() helper

[Cluster-devel] [PATCH v1] gfs2: increase usage of folio_next_index() helper

[Minjie Du]

Simplify code pattern of 'folio->index + folio_nr_pages(folio)' by using
the existing helper folio_next_index().

Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 fs/gfs2/aops.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c
index ae49256b7..5f0254237 100644
--- a/fs/gfs2/aops.c
+++ b/fs/gfs2/aops.c
@@ -272,8 +272,7 @@ static int gfs2_write_jdata_batch(struct address_space *mapping,
 				 * not be suitable for data integrity
 				 * writeout).
 				 */
-				*done_index = folio->index +
-					folio_nr_pages(folio);
+				*done_index = folio_next_index(folio);
 				ret = 1;
 				break;
 			}
-- 
2.39.0

[Cluster-devel] [PATCH v1] gfs2: increase usage of folio_next_index() helper

[Andreas Gruenbacher]

Minjie,

On Mon, Jul 17, 2023 at 9:20?AM Minjie Du <duminjie@vivo.com> wrote:
> Simplify code pattern of 'folio->index + folio_nr_pages(folio)' by using
> the existing helper folio_next_index().
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
>  fs/gfs2/aops.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c
> index ae49256b7..5f0254237 100644
> --- a/fs/gfs2/aops.c
> +++ b/fs/gfs2/aops.c
> @@ -272,8 +272,7 @@ static int gfs2_write_jdata_batch(struct address_space *mapping,
>                                  * not be suitable for data integrity
>                                  * writeout).
>                                  */
> -                               *done_index = folio->index +
> -                                       folio_nr_pages(folio);
> +                               *done_index = folio_next_index(folio);
>                                 ret = 1;
>                                 break;
>                         }
> --
> 2.39.0
>

Applied, thanks.

Email addresses like '"open list:GFS2 FILE SYSTEM"
<cluster-devel@redhat.com>' and 'open list
<linux-kernel@vger.kernel.org>' are not helpful though, so could you
please avoid using addresses like that in the future?

Thanks,
Andreas

[Cluster-devel] 回复: [PATCH v1] gfs2: increase usage of folio_next_index() helper

[杜敏杰]

Hi Andreas!


> Applied, thanks.

That's great, thank you!

> Email addresses like '"open list:GFS2 FILE SYSTEM"
> <cluster-devel@redhat.com>' and 'open list <linux-kernel@vger.kernel.org>' are not helpful 
> though, so could you please avoid using addresses like that in the future?

I see, thanks for reminding!


regards,
Minjie
-----????-----
???: Andreas Gruenbacher <agruenba@redhat.com> 
????: 2023?7?17? 15:42
???: ??? <duminjie@vivo.com>
??: Bob Peterson <rpeterso@redhat.com>; cluster-devel at redhat.com; linux-kernel at vger.kernel.org; opensource.kernel <opensource.kernel@vivo.com>
??: Re: [PATCH v1] gfs2: increase usage of folio_next_index() helper

Minjie,

On Mon, Jul 17, 2023 at 9:20?AM Minjie Du <duminjie@vivo.com> wrote:
> Simplify code pattern of 'folio->index + folio_nr_pages(folio)' by 
> using the existing helper folio_next_index().
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
>  fs/gfs2/aops.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c index 
> ae49256b7..5f0254237 100644
> --- a/fs/gfs2/aops.c
> +++ b/fs/gfs2/aops.c
> @@ -272,8 +272,7 @@ static int gfs2_write_jdata_batch(struct address_space *mapping,
>                                  * not be suitable for data integrity
>                                  * writeout).
>                                  */
> -                               *done_index = folio->index +
> -                                       folio_nr_pages(folio);
> +                               *done_index = folio_next_index(folio);
>                                 ret = 1;
>                                 break;
>                         }
> --
> 2.39.0
>

Applied, thanks.

Email addresses like '"open list:GFS2 FILE SYSTEM"
<cluster-devel@redhat.com>' and 'open list <linux-kernel@vger.kernel.org>' are not helpful though, so could you please avoid using addresses like that in the future?

Thanks,
Andreas