From: Andreas Gruenbacher <agruenba@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH dlm/next 1/4] fs: dlm: replace sanity checks with WARN_ON
Date: Thu, 17 Feb 2022 15:47:35 +0100 [thread overview]
Message-ID: <CAHc6FU4f34yutmcBA-GrZPUwjTgMAXBHuCzzFpMP_=cWQ-k3pQ@mail.gmail.com> (raw)
In-Reply-To: <CAK-6q+jKKr3hx29QMmz9jgoBNhs0NiyCEC8czYvg55dDr6Kkjw@mail.gmail.com>
On Thu, Feb 17, 2022 at 3:03 PM Alexander Aring <aahringo@redhat.com> wrote:
> On Wed, Feb 16, 2022 at 7:41 PM Andreas Gruenbacher <agruenba@redhat.com> wrote:
> >
> > There's also an unnecessary INIT_LIST_HEAD() in send_op().
> >
>
> please send a patch in a form which makes it easy to apply. Also
> please explain exactly why an "INIT_LIST_HEAD()" is not needed here
> rather than just stating that the init isn't needed.
The reason why the INIT_LIST_HEAD is unnecessary is because it
initializes op->list, and two lines further down, the list_add_tail
overrides op->list.
Do with this report whatever you want, but don't expect me to spend
extra time on it.
Andreas
next prev parent reply other threads:[~2022-02-17 14:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 15:53 [Cluster-devel] [PATCH dlm/next 0/4] fs: dlm: cleanup plock code Alexander Aring
2022-02-16 15:53 ` [Cluster-devel] [PATCH dlm/next 1/4] fs: dlm: replace sanity checks with WARN_ON Alexander Aring
2022-02-16 16:08 ` Andreas Gruenbacher
2022-02-16 16:16 ` Alexander Aring
2022-02-16 16:25 ` Alexander Aring
2022-02-16 16:26 ` Alexander Aring
2022-02-17 0:36 ` Andreas Gruenbacher
2022-02-17 14:02 ` Alexander Aring
2022-02-17 16:54 ` David Teigland
2022-02-17 0:41 ` Andreas Gruenbacher
2022-02-17 14:03 ` Alexander Aring
2022-02-17 14:47 ` Andreas Gruenbacher [this message]
2022-02-16 15:53 ` [Cluster-devel] [PATCH dlm/next 2/4] fs: dlm: cleanup plock_op vs plock_xop Alexander Aring
2022-02-16 15:53 ` [Cluster-devel] [PATCH dlm/next 3/4] fs: dlm: rearrange async condition return Alexander Aring
2022-02-16 15:53 ` [Cluster-devel] [PATCH dlm/next 4/4] fs: dlm: improve plock logging if interrupted Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHc6FU4f34yutmcBA-GrZPUwjTgMAXBHuCzzFpMP_=cWQ-k3pQ@mail.gmail.com' \
--to=agruenba@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).