From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andreas Gruenbacher <agruenba@redhat.com>
Date: Thu, 17 Feb 2022 15:47:35 +0100
Subject: [Cluster-devel] [PATCH dlm/next 1/4] fs: dlm: replace sanity
 checks with WARN_ON
In-Reply-To: <CAK-6q+jKKr3hx29QMmz9jgoBNhs0NiyCEC8czYvg55dDr6Kkjw@mail.gmail.com>
References: <20220216155307.2994688-1-aahringo@redhat.com>
	<20220216155307.2994688-2-aahringo@redhat.com>
	<CAHc6FU77jwdsDv_FGCFxrUVn_DOEqGrKEkB8c7N2pAF_j5Xo+A@mail.gmail.com>
	<CAK-6q+id1tmHL2GXBqOsJh53pbyH5rdTAgLeXdqUj4D6kZvkow@mail.gmail.com>
	<CAHc6FU4yypWqE+BZx4AstMYHkzoSDV5jVndYY7jYk7L1v20isg@mail.gmail.com>
	<20220217004142.551299-1-agruenba@redhat.com>
	<CAK-6q+jKKr3hx29QMmz9jgoBNhs0NiyCEC8czYvg55dDr6Kkjw@mail.gmail.com>
Message-ID: <CAHc6FU4f34yutmcBA-GrZPUwjTgMAXBHuCzzFpMP_=cWQ-k3pQ@mail.gmail.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

On Thu, Feb 17, 2022 at 3:03 PM Alexander Aring <aahringo@redhat.com> wrote:
> On Wed, Feb 16, 2022 at 7:41 PM Andreas Gruenbacher <agruenba@redhat.com> wrote:
> >
> > There's also an unnecessary INIT_LIST_HEAD() in send_op().
> >
>
> please send a patch in a form which makes it easy to apply. Also
> please explain exactly why an "INIT_LIST_HEAD()" is not needed here
> rather than just stating that the init isn't needed.

The reason why the INIT_LIST_HEAD is unnecessary is because it
initializes op->list, and two lines further down, the list_add_tail
overrides op->list.

Do with this report whatever you want, but don't expect me to spend
extra time on it.

Andreas