* [Cluster-devel] [PATCH] gfs2: remove redundant variable 'moved'
@ 2018-07-17 14:59 Colin King
2018-07-17 16:08 ` Andreas Gruenbacher
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2018-07-17 14:59 UTC (permalink / raw)
To: cluster-devel.redhat.com
From: Colin Ian King <colin.king@canonical.com>
Variable 'moved' s being assigned but is never used hence it is
redundant and can be removed.
Cleans up clang warning:
warning: variable 'moved' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
fs/gfs2/dir.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c
index d97ad89955d1..e37002560c11 100644
--- a/fs/gfs2/dir.c
+++ b/fs/gfs2/dir.c
@@ -1011,7 +1011,7 @@ static int dir_split_leaf(struct inode *inode, const struct qstr *name)
u64 bn, leaf_no;
__be64 *lp;
u32 index;
- int x, moved = 0;
+ int x;
int error;
index = name->hash >> (32 - dip->i_depth);
@@ -1113,8 +1113,6 @@ static int dir_split_leaf(struct inode *inode, const struct qstr *name)
if (!prev)
prev = dent;
-
- moved = 1;
} else {
prev = dent;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* [Cluster-devel] [PATCH] gfs2: remove redundant variable 'moved'
2018-07-17 14:59 [Cluster-devel] [PATCH] gfs2: remove redundant variable 'moved' Colin King
@ 2018-07-17 16:08 ` Andreas Gruenbacher
0 siblings, 0 replies; 2+ messages in thread
From: Andreas Gruenbacher @ 2018-07-17 16:08 UTC (permalink / raw)
To: cluster-devel.redhat.com
Colin,
On 17 July 2018 at 16:59, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable 'moved' s being assigned but is never used hence it is
> redundant and can be removed.
>
> Cleans up clang warning:
> warning: variable 'moved' set but not used [-Wunused-but-set-variable]
thanks. I've looked up since when the variable is unused and added
that info. The patch is on for-next now.
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> fs/gfs2/dir.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c
> index d97ad89955d1..e37002560c11 100644
> --- a/fs/gfs2/dir.c
> +++ b/fs/gfs2/dir.c
> @@ -1011,7 +1011,7 @@ static int dir_split_leaf(struct inode *inode, const struct qstr *name)
> u64 bn, leaf_no;
> __be64 *lp;
> u32 index;
> - int x, moved = 0;
> + int x;
> int error;
>
> index = name->hash >> (32 - dip->i_depth);
> @@ -1113,8 +1113,6 @@ static int dir_split_leaf(struct inode *inode, const struct qstr *name)
>
> if (!prev)
> prev = dent;
> -
> - moved = 1;
> } else {
> prev = dent;
> }
> --
> 2.17.1
>
Andreas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-17 16:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-17 14:59 [Cluster-devel] [PATCH] gfs2: remove redundant variable 'moved' Colin King
2018-07-17 16:08 ` Andreas Gruenbacher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).