From: Andreas Gruenbacher <agruenba@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [GFS2 PATCH] gfs2: simplify code with nq_init functions
Date: Thu, 18 Jun 2020 18:17:18 +0200 [thread overview]
Message-ID: <CAHc6FU7aFDYXGp9Ng5c9XT7j6WUAtGWVTaN9EnYaiguiZ+9uFA@mail.gmail.com> (raw)
In-Reply-To: <1194682176.34134614.1592327973401.JavaMail.zimbra@redhat.com>
Hi Bob,
On Tue, Jun 16, 2020 at 7:19 PM Bob Peterson <rpeterso@redhat.com> wrote:
> This patch simply cleans up some code to make it more readable by
> using helper functions gfs2_glock_nq_init and dq_uninit instead of
> doing things manually.
the more complicated call sequence [gfs2_holder_init ... gfs2_glock_nq
... gfs2_glock_dq ... gfs2_holder_uninit] produces better code than
just [gfs2_glock_nq_init ... gfs2_glock_dq_uninit]. I wonder if
there's a way to implement those primitives so that the compiler will
automatically produce the better code?
Andreas
prev parent reply other threads:[~2020-06-18 16:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <850442235.34134581.1592327923140.JavaMail.zimbra@redhat.com>
2020-06-16 17:19 ` [Cluster-devel] [GFS2 PATCH] gfs2: simplify code with nq_init functions Bob Peterson
2020-06-18 16:17 ` Andreas Gruenbacher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHc6FU7aFDYXGp9Ng5c9XT7j6WUAtGWVTaN9EnYaiguiZ+9uFA@mail.gmail.com \
--to=agruenba@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).