cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Andreas Gruenbacher <agruenba@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [GFS2 v3 PATCH 0/3] gfs2: Misc withdraw patches (version 3)
Date: Thu, 25 Aug 2022 17:59:22 +0200	[thread overview]
Message-ID: <CAHc6FU7zAh19pT6j6secT2NsRHNYT3stL2dPeQ5+sZarQLng8A@mail.gmail.com> (raw)
In-Reply-To: <20220818183238.121677-1-rpeterso@redhat.com>

On Thu, Aug 18, 2022 at 8:32 PM Bob Peterson <rpeterso@redhat.com> wrote:
> This is version 3 which has further simplification and improvements.
>
> This patch set fixes a few bugs in how gfs2 handles file systems after
> withdraw. In an ideal world, after a file system is withdrawn, users
> should be able to unmount the file system without problems. However, we
> discovered three problems that prevented clean unmounts:
>
> 1. A duplicate iput of the journal after attempted recovery caused
>    kernel panics after withdraw.
> 2. After withdraw, unmount would hang for its alloted timeout period
>    when glocks had waiters queued that, due to the withdraw, could
>    never be granted.
> 3. Unmount would similarly hang when the withdraw prevented an outgoing
>    request to dlm, but so the glock was never unlocked.
>
> Bob Peterson (3):
>   gfs2: Prevent double iput for journal on error
>   gfs2: Dequeue waiters when withdrawn
>   gfs2: Clear flags when withdraw prevents xmote
>
>  fs/gfs2/glock.c | 36 ++++++++++++++++++++++++++++++++++--
>  fs/gfs2/glock.h |  1 +
>  fs/gfs2/util.c  |  6 ++++++
>  3 files changed, 41 insertions(+), 2 deletions(-)
>
> --
> 2.37.2
>

Pushed to for-next.

Thanks,
Andreas


      parent reply	other threads:[~2022-08-25 15:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-18 18:32 [Cluster-devel] [GFS2 v3 PATCH 0/3] gfs2: Misc withdraw patches (version 3) Bob Peterson
2022-08-18 18:32 ` [Cluster-devel] [GFS2 v3 PATCH 1/3] gfs2: Prevent double iput for journal on error Bob Peterson
2022-08-18 18:32 ` [Cluster-devel] [GFS2 v3 PATCH 2/3] gfs2: Dequeue waiters when withdrawn Bob Peterson
2022-08-18 18:32 ` [Cluster-devel] [GFS2 v3 PATCH 3/3] gfs2: Clear flags when withdraw prevents xmote Bob Peterson
2022-08-25 15:59 ` Andreas Gruenbacher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHc6FU7zAh19pT6j6secT2NsRHNYT3stL2dPeQ5+sZarQLng8A@mail.gmail.com \
    --to=agruenba@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).