cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [GIT PULL] gfs2 fix
Date: Tue, 6 Jun 2023 05:55:19 -0700	[thread overview]
Message-ID: <CAHk-=wi_P4tOWCbZYo11u5vbB+tTxCSGwKC9m71y-QdbZP8zKA@mail.gmail.com> (raw)
In-Reply-To: <20230606124800.1151665-1-agruenba@redhat.com>

On Tue, Jun 6, 2023 at 5:48?AM Andreas Gruenbacher <agruenba@redhat.com> wrote:
>
> - Don't get stuck writing page onto itself under direct I/O.

Btw, is there a test for this DIO case?

We've had the deadlock issue on t page lock (or for inode locks or
whatever) for normal IO when faulting in the same page that is written
to, and we have as pattern for solving that and I think there are
filesystem tests that trigger this.

But the DIO pattern is a bit different, with the whole "invalidate
page cache: issue, and the fact that you send this patch now (rather
than years ago) makes me wonder about test coverage for this all?

                Linus


  reply	other threads:[~2023-06-06 12:55 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-06 12:48 [Cluster-devel] [GIT PULL] gfs2 fix Andreas Gruenbacher
2023-06-06 12:55 ` Linus Torvalds [this message]
2023-06-06 13:32   ` Andreas Gruenbacher
2023-06-06 13:22 ` pr-tracker-bot
  -- strict thread matches above, loose matches on Subject: below --
2022-04-26 14:54 Andreas Gruenbacher
2022-04-26 18:31 ` Linus Torvalds
2022-04-26 21:27   ` Andreas Gruenbacher
2022-04-26 23:33     ` Linus Torvalds
2022-04-27 12:29       ` Andreas Gruenbacher
2022-04-27 17:13         ` Linus Torvalds
2022-04-27 19:41           ` Andreas Gruenbacher
2022-04-27 20:25             ` Linus Torvalds
2022-04-27 21:26               ` Andreas Gruenbacher
2022-04-27 22:20                 ` Linus Torvalds
2022-04-28  0:00                   ` Linus Torvalds
2022-04-28 13:26                     ` Andreas Gruenbacher
2022-04-28 17:09                       ` Linus Torvalds
2022-04-28 17:17                         ` Linus Torvalds
2022-04-28 17:21                           ` Andreas Gruenbacher
2022-04-28 17:38                         ` Andreas Gruenbacher
2022-05-02 18:31                           ` Linus Torvalds
2022-05-02 18:58                             ` Linus Torvalds
2022-05-02 20:24                               ` Andreas Gruenbacher
2022-05-03  8:56                             ` Andreas Gruenbacher
2022-05-03 13:30                               ` Andreas Gruenbacher
2022-05-03 16:19                               ` Linus Torvalds
2022-05-03 16:41                                 ` Andreas Gruenbacher
2022-05-03 16:50                                   ` Linus Torvalds
2022-05-03 21:35                               ` Andreas Gruenbacher
2022-05-03 22:41                                 ` Linus Torvalds
2022-05-04 17:52                                   ` Andreas Gruenbacher
2022-04-28 18:16                       ` pr-tracker-bot
2022-04-26 19:07 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wi_P4tOWCbZYo11u5vbB+tTxCSGwKC9m71y-QdbZP8zKA@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).