From: Ryusuke Konishi <konishi.ryusuke@gmail.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 9/9] mm: return an ERR_PTR from __filemap_get_folio
Date: Wed, 18 Jan 2023 21:39:08 +0900 [thread overview]
Message-ID: <CAKFNMomcjvUSh-nS1MqptYdiT-1frRsmHgx2mHBBm_588kprrQ@mail.gmail.com> (raw)
In-Reply-To: <20230118094329.9553-10-hch@lst.de>
On Wed, Jan 18, 2023 at 7:41 PM Christoph Hellwig wrote:
>
> Instead of returning NULL for all errors, distinguish between:
>
> - no entry found and not asked to allocated (-ENOENT)
> - failed to allocate memory (-ENOMEM)
> - would block (-EAGAIN)
>
> so that callers don't have to guess the error based on the passed
> in flags.
>
> Also pass through the error through the direct callers:
> filemap_get_folio, filemap_lock_folio filemap_grab_folio
> and filemap_get_incore_folio.
As for the comments describing the return values of these callers,
isn't it necessary to rewrite the value from NULL in case of errors ?
Regards,
Ryusuke Konishi
next prev parent reply other threads:[~2023-01-18 12:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 9:43 [Cluster-devel] return an ERR_PTR from __filemap_get_folio Christoph Hellwig
2023-01-18 9:43 ` [Cluster-devel] [PATCH 1/9] mm: don't look at xarray value entries in split_huge_pages_in_file Christoph Hellwig
2023-01-18 13:47 ` Matthew Wilcox
2023-01-18 9:43 ` [Cluster-devel] [PATCH 2/9] mm: make mapping_get_entry available outside of filemap.c Christoph Hellwig
2023-01-18 13:49 ` Matthew Wilcox
2023-01-18 9:43 ` [Cluster-devel] [PATCH 3/9] mm: use filemap_get_entry in filemap_get_incore_folio Christoph Hellwig
2023-01-18 13:49 ` Matthew Wilcox
2023-01-18 9:43 ` [Cluster-devel] [PATCH 4/9] shmem: remove shmem_get_partial_folio Christoph Hellwig
2023-01-18 13:57 ` Brian Foster
2023-01-18 16:43 ` Christoph Hellwig
2023-01-18 16:50 ` Brian Foster
2023-01-18 9:43 ` [Cluster-devel] [PATCH 5/9] shmem: open code the page cache lookup in shmem_get_folio_gfp Christoph Hellwig
2023-01-18 9:43 ` [Cluster-devel] [PATCH 6/9] mm: remove FGP_ENTRY Christoph Hellwig
2023-01-18 9:43 ` [Cluster-devel] [PATCH 7/9] gfs2: handle a NULL folio in gfs2_jhead_process_page Christoph Hellwig
2023-01-18 16:00 ` Matthew Wilcox
2023-01-18 16:24 ` Andreas Gruenbacher
2023-01-18 16:42 ` Christoph Hellwig
2023-01-18 9:43 ` [Cluster-devel] [PATCH 8/9] btrfs: handle a NULL folio in extent_range_redirty_for_io Christoph Hellwig
2023-01-18 16:08 ` Matthew Wilcox
2023-01-18 16:42 ` Christoph Hellwig
2023-01-18 9:43 ` [Cluster-devel] [PATCH 9/9] mm: return an ERR_PTR from __filemap_get_folio Christoph Hellwig
2023-01-18 12:39 ` Ryusuke Konishi [this message]
2023-01-18 16:42 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKFNMomcjvUSh-nS1MqptYdiT-1frRsmHgx2mHBBm_588kprrQ@mail.gmail.com \
--to=konishi.ryusuke@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).