From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryusuke Konishi Date: Fri, 27 Jan 2023 02:24:29 +0900 Subject: [Cluster-devel] [PATCH 7/7] mm: return an ERR_PTR from __filemap_get_folio In-Reply-To: <20230121065755.1140136-8-hch@lst.de> References: <20230121065755.1140136-1-hch@lst.de> <20230121065755.1140136-8-hch@lst.de> Message-ID: List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Sat, Jan 21, 2023 at 3:59 PM Christoph Hellwig wrote: > > Instead of returning NULL for all errors, distinguish between: > > - no entry found and not asked to allocated (-ENOENT) > - failed to allocate memory (-ENOMEM) > - would block (-EAGAIN) > > so that callers don't have to guess the error based on the passed > in flags. > > Also pass through the error through the direct callers: > filemap_get_folio, filemap_lock_folio filemap_grab_folio > and filemap_get_incore_folio. > > Signed-off-by: Christoph Hellwig > --- For > fs/nilfs2/page.c | 6 +++--- Acked-by: Ryusuke Konishi Thanks, Ryusuke Konishi