* [Cluster-devel] [PATCH] GFS2: return error if malloc failed in gfs2_rs_alloc()
@ 2013-03-11 15:01 Wei Yongjun
2013-03-11 16:09 ` Steven Whitehouse
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-03-11 15:01 UTC (permalink / raw)
To: cluster-devel.redhat.com
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
The error code in gfs2_rs_alloc() is set to ENOMEM when error
but never be used, instead, gfs2_rs_alloc() always return 0.
Fix to return 'error'.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
fs/gfs2/rgrp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
index 9d16a6f..b850198 100644
--- a/fs/gfs2/rgrp.c
+++ b/fs/gfs2/rgrp.c
@@ -576,7 +576,7 @@ int gfs2_rs_alloc(struct gfs2_inode *ip)
RB_CLEAR_NODE(&ip->i_res->rs_node);
out:
up_write(&ip->i_rw_mutex);
- return 0;
+ return error;
}
static void dump_rs(struct seq_file *seq, const struct gfs2_blkreserv *rs)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Cluster-devel] [PATCH] GFS2: return error if malloc failed in gfs2_rs_alloc()
2013-03-11 15:01 [Cluster-devel] [PATCH] GFS2: return error if malloc failed in gfs2_rs_alloc() Wei Yongjun
@ 2013-03-11 16:09 ` Steven Whitehouse
0 siblings, 0 replies; 2+ messages in thread
From: Steven Whitehouse @ 2013-03-11 16:09 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
Now in the GFS2 -nmw tree. Thanks,
Steve.
On Mon, 2013-03-11 at 23:01 +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> The error code in gfs2_rs_alloc() is set to ENOMEM when error
> but never be used, instead, gfs2_rs_alloc() always return 0.
> Fix to return 'error'.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> fs/gfs2/rgrp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
> index 9d16a6f..b850198 100644
> --- a/fs/gfs2/rgrp.c
> +++ b/fs/gfs2/rgrp.c
> @@ -576,7 +576,7 @@ int gfs2_rs_alloc(struct gfs2_inode *ip)
> RB_CLEAR_NODE(&ip->i_res->rs_node);
> out:
> up_write(&ip->i_rw_mutex);
> - return 0;
> + return error;
> }
>
> static void dump_rs(struct seq_file *seq, const struct gfs2_blkreserv *rs)
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-11 16:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-11 15:01 [Cluster-devel] [PATCH] GFS2: return error if malloc failed in gfs2_rs_alloc() Wei Yongjun
2013-03-11 16:09 ` Steven Whitehouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).