cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Fabio M. Di Nitto <fabbione@ubuntu.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] gfs2 umount: support fake -r option
Date: Sat, 19 Jan 2008 06:58:17 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.64.0801190655490.6826@trider-g7> (raw)


Hi guys,

in certain situations where gfs2 init scripts are not used to umount gfs2 
volume, we endup with umount.gfs2 being invoked with -r option and this 
fails because we don't know what to do with this option.

The patch simply ack the option and ignores it for now allowing a reboot 
process to keep going.

Please ACK or apply.

Fabio

Index: umount.gfs2.c
===================================================================
RCS file: /cvs/cluster/cluster/gfs2/mount/umount.gfs2.c,v
retrieving revision 1.15
diff -u -r1.15 umount.gfs2.c
--- umount.gfs2.c	22 Aug 2007 08:58:46 -0000	1.15
+++ umount.gfs2.c	19 Jan 2008 05:54:22 -0000
@@ -52,7 +52,7 @@
  	/* FIXME: check for "quiet" option and don't print in that case */

  	while (cont) {
-		optchar = getopt(argc, argv, "fhVvX:");
+		optchar = getopt(argc, argv, "fhVvX:r");

  		switch (optchar) {
  		case EOF:
@@ -79,6 +79,9 @@
  			print_version();
  			exit(EXIT_SUCCESS);

+		case 'r':
+			break; /* used by umount to remount ro if umount fails */
+
  		default:
  			break;
  		}

--
I'm going to make him an offer he can't refuse.



             reply	other threads:[~2008-01-19  5:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-19  5:58 Fabio M. Di Nitto [this message]
2008-01-21 14:15 ` [Cluster-devel] [PATCH] gfs2 umount: support fake -r option David Teigland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0801190655490.6826@trider-g7 \
    --to=fabbione@ubuntu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).