cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Fabio M. Di Nitto <fdinitto@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] Fix libdlm static build
Date: Thu, 3 Jul 2008 19:49:59 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0807031948580.27368@trider-g7> (raw)
In-Reply-To: <486CCEBE.3050809@redhat.com>

On Thu, 3 Jul 2008, Christine Caulfield wrote:

> Fabio M. Di Nitto wrote:
>> 
>> Hi David,
>> 
>> the objects included in the static version of dlm are different from the 
>> one in the shared lib. This is generally wrong as they should be the same.
>> 
>> the patch addresses the problem by killing .po files in favour of more 
>> common .o and changing the linking targets.
>> 
>> the patch applies to both master and stable2. rhel branches are also 
>> affected by other problems (_lt is linked to pthread) but i don't think 
>> it's wise to change it.
>> 
>> Please review and apply.
>> 
>> Thanks
>> Fabio
>>

[SNIP]

> I don't understand the problem you are trying to fix here.

To have the same objects in both.

> Having PIC objects 
> in the dynamic library and non-PIC in the static is perfectly standard 
> practice.

Why does dlm needs to have it different from the rest of our libraries? Is 
there a special reason?

Fabio

--
I'm going to make him an offer he can't refuse.



  reply	other threads:[~2008-07-03 17:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-03 11:44 [Cluster-devel] [PATCH] Fix libdlm static build Fabio M. Di Nitto
2008-07-03 13:06 ` Christine Caulfield
2008-07-03 17:49   ` Fabio M. Di Nitto [this message]
2008-07-03 17:53   ` Lon Hohberger
2008-07-04  7:20     ` Christine Caulfield
2008-07-04  7:34       ` Fabio M. Di Nitto
2008-07-04  8:54         ` Christine Caulfield
2008-07-04 11:28           ` Fabio M. Di Nitto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0807031948580.27368@trider-g7 \
    --to=fdinitto@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).