From: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v4] [next] dlm: replace one-element array with fixed size array
Date: Wed, 12 Oct 2022 09:11:44 +1300 [thread overview]
Message-ID: <Y0XOAAOLPfj/VHco@mail.google.com> (raw)
In-Reply-To: <202210111305.743F591@keescook>
On Tue, Oct 11, 2022 at 01:06:32PM -0700, Kees Cook wrote:
> On Wed, Oct 12, 2022 at 09:04:15AM +1300, Paulo Miguel Almeida wrote:
> > error = -ENOMEM;
> >
> > - ls = kzalloc(sizeof(struct dlm_ls) + namelen, GFP_NOFS);
> > + ls = kzalloc(sizeof(struct dlm_ls), GFP_NOFS);
> ^^^^^^^^^^^^^^^^^^^^
> I think you forgot the suggestion Gustavo had here. :) Preferred style would
> be:
> sizeof(*ls)
>
Ooops, I hadn't seen that one =O
Alright, v5 in the making
Paulo A.
next prev parent reply other threads:[~2022-10-11 20:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-08 23:17 [Cluster-devel] [PATCH v2][next] dlm: Replace one-element array with flexible-array member Paulo Miguel Almeida
2022-10-09 0:18 ` Kees Cook
2022-10-09 2:05 ` Paulo Miguel Almeida
2022-10-09 4:03 ` Kees Cook
2022-10-10 21:00 ` David Teigland
2022-10-10 22:35 ` Kees Cook
2022-10-11 15:20 ` David Teigland
2022-10-11 18:44 ` Paulo Miguel Almeida
2022-10-11 20:04 ` [Cluster-devel] [PATCH v4] [next] dlm: replace one-element array with fixed size array Paulo Miguel Almeida
2022-10-11 20:06 ` Kees Cook
2022-10-11 20:11 ` Paulo Miguel Almeida [this message]
2022-10-11 20:23 ` [Cluster-devel] [PATCH v5] " Paulo Miguel Almeida
2022-10-11 20:26 ` Gustavo A. R. Silva
2022-10-11 22:18 ` Kees Cook
2022-11-04 5:00 ` Paulo Miguel Almeida
2022-11-04 17:50 ` Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0XOAAOLPfj/VHco@mail.google.com \
--to=paulo.miguel.almeida.rodenas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).