From: Matthew Wilcox <willy@infradead.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] filelock: move file locking definitions to separate header file
Date: Tue, 22 Nov 2022 03:51:31 +0000 [thread overview]
Message-ID: <Y3xHQwM3UiD/SK0K@casper.infradead.org> (raw)
In-Reply-To: <20221120210004.381842-1-jlayton@kernel.org>
On Sun, Nov 20, 2022 at 03:59:57PM -0500, Jeff Layton wrote:
> Move the file locking definitions to a new header file, and add the
> appropriate #include directives to the source files that need them. By
> doing this we trim down fs.h a bit and limit the amount of rebuilding
> that has to be done when we make changes to the file locking APIs.
I'm in favour of this in general, but I think there's a few implicit
includes. Can you create a test.c that only #include
<linnux/filelock.h> and see if there's anything missing?
> + wait_queue_head_t fl_wait;
> + struct file *fl_file;
These two seem undefined at this point.
> + struct fasync_struct * fl_fasync; /* for lease break notifications */
Likewise.
next prev parent reply other threads:[~2022-11-22 3:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-20 20:59 [Cluster-devel] [PATCH] filelock: move file locking definitions to separate header file Jeff Layton
2022-11-21 1:26 ` Xiubo Li
2022-11-22 3:44 ` Matthew Wilcox
2022-11-21 7:59 ` Christoph Hellwig
2022-11-21 9:19 ` Christian Brauner
2022-11-21 14:40 ` Chuck Lever III
2022-11-21 15:31 ` David Howells
2022-11-21 16:21 ` Steve French
2022-11-21 16:53 ` Darrick J. Wong
2022-11-21 17:16 ` Jeff Layton
2022-11-21 17:27 ` Darrick J. Wong
2022-11-21 19:06 ` Jeff Layton
2022-11-22 1:51 ` Joseph Qi
2022-11-22 12:20 ` Jeff Layton
2022-11-22 13:54 ` Joseph Qi
2022-11-22 3:51 ` Matthew Wilcox [this message]
2022-11-22 6:06 ` Christoph Hellwig
2022-11-22 11:13 ` Jeff Layton
2022-11-25 3:34 ` Al Viro
2022-11-25 3:48 ` Al Viro
2022-11-25 13:23 ` Jeff Layton
2022-11-25 16:44 ` Al Viro
2022-11-28 10:53 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3xHQwM3UiD/SK0K@casper.infradead.org \
--to=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).