From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Fri, 23 Dec 2022 23:23:34 -0800 Subject: [Cluster-devel] [RFC v3 4/7] iomap: Add iomap_folio_prepare helper In-Reply-To: References: <20221216150626.670312-1-agruenba@redhat.com> <20221216150626.670312-5-agruenba@redhat.com> Message-ID: List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Dec 23, 2022 at 10:05:05PM +0100, Andreas Gr?nbacher wrote: > > I'd name this __iomap_get_folio to match __filemap_get_folio. > > I was looking at it from the filesystem point of view: this helper is > meant to be used in ->folio_prepare() handlers, so > iomap_folio_prepare() seemed to be a better name than > __iomap_get_folio(). Well, I think the right name for the methods that gets a folio is probably ->folio_get anyway.