From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Tue, 10 Jan 2023 00:48:15 -0800 Subject: [Cluster-devel] [RFC v6 06/10] iomap: Add __iomap_get_folio helper In-Reply-To: <20230108194034.1444764-7-agruenba@redhat.com> References: <20230108194034.1444764-1-agruenba@redhat.com> <20230108194034.1444764-7-agruenba@redhat.com> Message-ID: List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Sun, Jan 08, 2023 at 08:40:30PM +0100, Andreas Gruenbacher wrote: > +static struct folio *__iomap_get_folio(struct iomap_iter *iter, loff_t pos, > + size_t len) > +{ > + const struct iomap_page_ops *page_ops = iter->iomap.page_ops; > + > + if (page_ops && page_ops->page_prepare) > + return page_ops->page_prepare(iter, pos, len); > + else > + return iomap_get_folio(iter, pos); Nit: No need for an else after the return. Otherwise looks good: Reviewed-by: Christoph Hellwig