From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Sun, 8 Jan 2023 09:29:38 -0800 Subject: [Cluster-devel] [PATCH v5 5/9] iomap/gfs2: Get page in page_prepare handler In-Reply-To: <20221231150919.659533-6-agruenba@redhat.com> References: <20221231150919.659533-1-agruenba@redhat.com> <20221231150919.659533-6-agruenba@redhat.com> Message-ID: List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit > + if (page_ops && page_ops->page_prepare) > + folio = page_ops->page_prepare(iter, pos, len); > + else > + folio = iomap_get_folio(iter, pos); > + if (IS_ERR(folio)) > return PTR_ERR(folio); I'd love to have a iomap_get_folio helper for this sequence so that we match iomap_put_folio. That would require renaming the current iomap_get_folio to __iomap_get_folio. Otherwise this looks good: Reviewed-by: Christoph Hellwig