From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Foster Date: Wed, 18 Jan 2023 11:50:26 -0500 Subject: [Cluster-devel] [PATCH 4/9] shmem: remove shmem_get_partial_folio In-Reply-To: <20230118164358.GD7584@lst.de> References: <20230118094329.9553-1-hch@lst.de> <20230118094329.9553-5-hch@lst.de> <20230118164358.GD7584@lst.de> Message-ID: List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Jan 18, 2023 at 05:43:58PM +0100, Christoph Hellwig wrote: > On Wed, Jan 18, 2023 at 08:57:05AM -0500, Brian Foster wrote: > > This all seems reasonable to me at a glance, FWIW, but I am a little > > curious why this wouldn't split up into two changes. I.e., switch this > > over to filemap_get_entry() to minimally remove the FGP_ENTRY dependency > > without a behavior change, then (perhaps after the next patch) introduce > > SGP_FIND in a separate patch. That makes it easier to review and > > potentially undo if it happens to pose a problem in the future. Hm? > > The minimal change to filemap_get_entry would require to add the > lock, check mapping and retry loop and thus add a fair amount of > code. So I looked for ways to avoid that and came up with this > version. But if there is a strong preference to first open code > the logic and then later consolidate it I could do that. > Ok. Not a strong preference from me. I don't think it's worth complicating that much just to split up. Brian