From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Tue, 6 Jul 2021 06:03:50 +0100 Subject: [Cluster-devel] [PATCH v2 1/2] iomap: Don't create iomap_page objects for inline files In-Reply-To: <20210705181824.2174165-2-agruenba@redhat.com> References: <20210705181824.2174165-1-agruenba@redhat.com> <20210705181824.2174165-2-agruenba@redhat.com> Message-ID: List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Jul 05, 2021 at 08:18:23PM +0200, Andreas Gruenbacher wrote: > In iomap_readpage_actor, don't create iop objects for inline inodes. > Otherwise, iomap_read_inline_data will set PageUptodate without setting > iop->uptodate, and iomap_page_release will eventually complain. > > To prevent this kind of bug from occurring in the future, make sure the > page doesn't have private data attached in iomap_read_inline_data. > > Signed-off-by: Andreas Gruenbacher > Reviewed-by: Matthew Wilcox (Oracle) As mentioned last round I'd prefer to simply not create the iomap_page at all in the readpage/readpages path. Also this patch needs to go after the current patch 2 to be bisection clean.