* [Cluster-devel] [syzbot] WARNING in folio_account_dirtied
[not found] <000000000000f121b705df9f5a0a@google.com>
@ 2022-05-22 23:11 ` Matthew Wilcox
0 siblings, 0 replies; only message in thread
From: Matthew Wilcox @ 2022-05-22 23:11 UTC (permalink / raw)
To: cluster-devel.redhat.com
On Sun, May 22, 2022 at 01:13:22PM -0700, syzbot wrote:
> HEAD commit: ef1302160bfb Merge tag 'sound-5.18' of git://git.kernel.or..
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=17626629f00000
> kernel config: https://syzkaller.appspot.com/x/.config?x=d84df8e1a4c4d5a4
> dashboard link: https://syzkaller.appspot.com/bug?extid=8d1d62bfb63d6a480be1
> compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2
>
> Unfortunately, I don't have any reproducer for this issue yet.
Hmm. This looks like a gfs2 issue. Adding maintainers.
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+8d1d62bfb63d6a480be1 at syzkaller.appspotmail.com
>
> ------------[ cut here ]------------
> WARNING: CPU: 1 PID: 19258 at include/linux/backing-dev.h:264 folio_account_dirtied+0x61a/0x720 mm/page-writeback.c:2448
This is:
WARN_ON_ONCE(debug_locks &&
(!lockdep_is_held(&inode->i_lock) &&
!lockdep_is_held(&inode->i_mapping->i_pages.xa_lock) &&
!lockdep_is_held(&inode->i_wb->list_lock)));
The comment says:
* The caller must be
* holding either @inode->i_lock, the i_pages lock, or the
* associated wb's list_lock.
IIRC, gfs2 plays some fun games with mapping->host and inode->i_mapping,
so maybe there's something the VFS is trying to do for it that isn't
working as expected.
A similar problem was recently encountered and fixed with nilfs2.
https://lore.kernel.org/all/CAKFNMonQtBe=pjrUuACqzKL36RTWmvoULwzD9NCP7PET8B73bQ at mail.gmail.com/
https://lore.kernel.org/all/1647867427-30498-1-git-send-email-konishi.ryusuke at gmail.com/
This is the first time I recall seeing it with gfs2.
> Modules linked in:
> CPU: 1 PID: 19258 Comm: syz-executor.3 Not tainted 5.18.0-rc7-syzkaller-00015-gef1302160bfb #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
> RIP: 0010:inode_to_wb include/linux/backing-dev.h:261 [inline]
> RIP: 0010:folio_account_dirtied+0x61a/0x720 mm/page-writeback.c:2448
> Code: ff ff e9 6e fd ff ff e8 c4 6d d2 ff 4c 89 f7 4c 89 e6 48 83 c4 18 5b 41 5c 41 5d 41 5e 41 5f 5d e9 eb af 29 00 e8 a6 6d d2 ff <0f> 0b 43 80 3c 3c 00 0f 85 36 fd ff ff e9 39 fd ff ff 48 c7 c1 f4
> RSP: 0018:ffffc90002e5f840 EFLAGS: 00010093
> RAX: ffffffff81b3a75a RBX: 0000000000000000 RCX: ffff8880795c9d80
> RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
> RBP: ffff888140c8ef80 R08: ffffffff81b3a71e R09: fffff940003cd8c9
> R10: fffff940003cd8c9 R11: 1ffffd40003cd8c8 R12: 1ffff11028191df0
> R13: 0000000000000001 R14: ffffea0001e6c640 R15: dffffc0000000000
> FS: 0000555556a2c400(0000) GS:ffff8880b9b00000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 000000c0157c0000 CR3: 0000000034a53000 CR4: 00000000003506e0
> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> DR3: 000000000000003b DR6: 00000000ffff0ff0 DR7: 0000000000000400
> Call Trace:
> <TASK>
> __folio_mark_dirty+0x125/0x260 mm/page-writeback.c:2499
> __set_page_dirty include/linux/pagemap.h:1008 [inline]
> mark_buffer_dirty+0x263/0x560 fs/buffer.c:1105
> gfs2_unpin+0x116/0xa40 fs/gfs2/lops.c:111
> buf_lo_after_commit+0x172/0x1d0 fs/gfs2/lops.c:747
> lops_after_commit fs/gfs2/lops.h:49 [inline]
> gfs2_log_flush+0x1258/0x2770 fs/gfs2/log.c:1108
> do_sync+0xbe7/0xe60 fs/gfs2/quota.c:967
> gfs2_quota_sync+0x3da/0x8b0 fs/gfs2/quota.c:1310
> gfs2_sync_fs+0x49/0xb0 fs/gfs2/super.c:642
> sync_filesystem+0xe8/0x220 fs/sync.c:56
> generic_shutdown_super+0x6b/0x300 fs/super.c:445
> kill_block_super+0x79/0xd0 fs/super.c:1394
> deactivate_locked_super+0xa7/0xf0 fs/super.c:332
> cleanup_mnt+0x452/0x500 fs/namespace.c:1186
> task_work_run+0x146/0x1c0 kernel/task_work.c:164
> resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
> exit_to_user_mode_loop+0x134/0x160 kernel/entry/common.c:169
> exit_to_user_mode_prepare+0xad/0x110 kernel/entry/common.c:201
> __syscall_exit_to_user_mode_work kernel/entry/common.c:283 [inline]
> syscall_exit_to_user_mode+0x2e/0x70 kernel/entry/common.c:294
> entry_SYSCALL_64_after_hwframe+0x44/0xae
> RIP: 0033:0x7f1c2e88a557
> Code: ff ff ff f7 d8 64 89 01 48 83 c8 ff c3 66 0f 1f 44 00 00 31 f6 e9 09 00 00 00 66 0f 1f 84 00 00 00 00 00 b8 a6 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
> RSP: 002b:00007fff1b126788 EFLAGS: 00000246 ORIG_RAX: 00000000000000a6
> RAX: 0000000000000000 RBX: 0000000000000000 RCX: 00007f1c2e88a557
> RDX: 00007fff1b12685a RSI: 000000000000000a RDI: 00007fff1b126850
> RBP: 00007fff1b126850 R08: 00000000ffffffff R09: 00007fff1b126620
> R10: 0000555556a2d8b3 R11: 0000000000000246 R12: 00007f1c2e8e21f8
> R13: 00007fff1b127910 R14: 0000555556a2d810 R15: 00007fff1b127950
> </TASK>
>
>
> ---
> This report is generated by a bot. It may contain errors.
> See https://goo.gl/tpsmEJ for more information about syzbot.
> syzbot engineers can be reached at syzkaller at googlegroups.com.
>
> syzbot will keep track of this issue. See:
> https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
>
^ permalink raw reply [flat|nested] only message in thread