From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Date: Wed, 10 Aug 2022 21:43:58 +0100 Subject: [Cluster-devel] remove iomap_writepage v2 In-Reply-To: References: <20220719041311.709250-1-hch@lst.de> <20220728111016.uwbaywprzkzne7ib@quack3> <20220729092216.GE3493@suse.de> <20220729141145.GA31605@lst.de> Message-ID: List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Aug 01, 2022 at 11:31:50AM -0400, Johannes Weiner wrote: > XFS hasn't had a ->writepage call for a while. After LSF I internally > tested dropping btrfs' callback, and the results looked good: no OOM > kills with dirty/writeback pages remaining, performance parity. Then I > went on vacation and Christoph beat me to the patch :) To avoid duplicating work with you or Christoph ... it seems like the plan is to kill ->writepage entirely soon, so there's no point in me doing a sweep of all the filesystems to convert ->writepage to ->write_folio, correct? I assume the plan for filesystems which have a writepage but don't have a ->writepages (9p, adfs, affs, bfs, ecryptfs, gfs2, hostfs, jfs, minix, nilfs2, ntfs, ocfs2, reiserfs, sysv, ubifs, udf, ufs, vboxsf) is to give them a writepages, modelled on iomap_writepages(). Seems that adding a block_writepages() might be a useful thing for me to do?