From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sat, 6 May 2017 10:44:50 +0200 Subject: [Cluster-devel] [PATCH 07/10] dlm: Use kmalloc_array() in make_member_array() In-Reply-To: <4bd895d7-9448-928d-1e4c-42326ce20607@users.sourceforge.net> References: <4bd895d7-9448-928d-1e4c-42326ce20607@users.sourceforge.net> Message-ID: List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit From: Markus Elfring Date: Sat, 6 May 2017 09:19:17 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- fs/dlm/member.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/dlm/member.c b/fs/dlm/member.c index 9c47f1c14a8b..89257699d4e4 100644 --- a/fs/dlm/member.c +++ b/fs/dlm/member.c @@ -405,8 +405,7 @@ static void make_member_array(struct dlm_ls *ls) } ls->ls_total_weight = total; - - array = kmalloc(sizeof(int) * total, GFP_NOFS); + array = kmalloc_array(total, sizeof(*array), GFP_NOFS); if (!array) return; -- 2.12.2