From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 18/25] gfs2: Convert to properly refcounting bdi
Date: Wed, 12 Apr 2017 09:48:05 +0100 [thread overview]
Message-ID: <d6638e4f-13a8-a173-69ed-76d435327b93@redhat.com> (raw)
In-Reply-To: <20170412081641.GR9830@infradead.org>
Hi,
On 12/04/17 09:16, Christoph Hellwig wrote:
> On Wed, Mar 29, 2017 at 12:56:16PM +0200, Jan Kara wrote:
>> Similarly to set_bdev_super() GFS2 just used block device reference to
>> bdi. Convert it to properly getting bdi reference. The reference will
>> get automatically dropped on superblock destruction.
> Hmm, why iisn't gfs2 simply using the generic mount_bdev code?
>
> Otherwise looks fine:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
It is more or less. However we landed up copying it because we needed a
slight modification in order to cope with the metafs mounts. There may
be scope to factor out the common parts I guess. We cannot select the
root dentry until after we've parsed the mount command line, so it is
really just the last part of the function that is different,
Steve.
next prev parent reply other threads:[~2017-04-12 8:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 10:55 [Cluster-devel] [PATCH 0/25 v2] fs: Convert all embedded bdis into separate ones Jan Kara
2017-03-29 10:56 ` [Cluster-devel] [PATCH 04/25] fs: Provide infrastructure for dynamic BDIs in filesystems Jan Kara
2017-04-12 8:09 ` Christoph Hellwig
2017-03-29 10:56 ` [Cluster-devel] [PATCH 18/25] gfs2: Convert to properly refcounting bdi Jan Kara
2017-04-12 8:16 ` Christoph Hellwig
2017-04-12 8:48 ` Steven Whitehouse [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-04-12 10:24 [Cluster-devel] [PATCH 0/25 v3] fs: Convert all embedded bdis into separate ones Jan Kara
2017-04-12 10:24 ` [Cluster-devel] [PATCH 18/25] gfs2: Convert to properly refcounting bdi Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6638e4f-13a8-a173-69ed-76d435327b93@redhat.com \
--to=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).