From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Price <anprice@redhat.com>
Date: Fri, 29 Mar 2019 16:54:32 +0000
Subject: [Cluster-devel] [PATCH v3] gfs2: Convert gfs2 to fs_context
In-Reply-To: <201903280254.VAUSqkQY%lkp@intel.com>
References: <20190327144600.671-1-anprice@redhat.com>
	<201903280254.VAUSqkQY%lkp@intel.com>
Message-ID: <d715ace3-6552-e39c-6121-1de51cf40afd@redhat.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

On 27/03/2019 18:14, kbuild test robot wrote:
> Hi Andrew,
> 
> Thank you for the patch! Yet something to improve:
> 
> [auto build test ERROR on gfs2/for-next]
> [also build test ERROR on v5.1-rc2 next-20190327]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Andrew-Price/gfs2-Convert-gfs2-to-fs_context/20190328-005647
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git for-next

These failures are due to the wrong base. The patch was based on David 
Howells' mount-api-viro branch and not the gfs2 for-next one.

Andy

> config: i386-randconfig-x008-201912 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
> reproduce:
>          # save the attached .config to linux build tree
>          make ARCH=i386
> 
> All error/warnings (new ones prefixed by >>):
> 
>     fs/gfs2/ops_fstype.c: In function 'gfs2_get_tree':
>>> fs/gfs2/ops_fstype.c:1217:10: error: implicit declaration of function 'vfs_get_block_super'; did you mean 'vfs_get_super'? [-Werror=implicit-function-declaration]
>       error = vfs_get_block_super(fc, gfs2_fill_super);
>               ^~~~~~~~~~~~~~~~~~~
>               vfs_get_super
>     fs/gfs2/ops_fstype.c: In function 'test_meta_super':
>>> fs/gfs2/ops_fstype.c:1565:12: error: 'struct fs_context' has no member named 'bdev'
>       return (fc->bdev == s->s_bdev);
>                 ^~
>     fs/gfs2/ops_fstype.c: In function 'gfs2_meta_get_tree':
>     fs/gfs2/ops_fstype.c:1585:4: error: 'struct fs_context' has no member named 'bdev'
>       fc->bdev = path.dentry->d_sb->s_bdev;
>         ^~
>     fs/gfs2/ops_fstype.c: In function 'test_meta_super':
>>> fs/gfs2/ops_fstype.c:1566:1: warning: control reaches end of non-void function [-Wreturn-type]
>      }
>      ^
>     cc1: some warnings being treated as errors
> 
> vim +1217 fs/gfs2/ops_fstype.c
> 
>    1204	
>    1205	/**
>    1206	 * gfs2_get_tree - Get the GFS2 superblock and root directory
>    1207	 * @fc: The filesystem context
>    1208	 *
>    1209	 * Returns: 0 or -errno on error
>    1210	 */
>    1211	static int gfs2_get_tree(struct fs_context *fc)
>    1212	{
>    1213		struct gfs2_args *args = fc->fs_private;
>    1214		struct gfs2_sbd *sdp;
>    1215		int error;
>    1216	
>> 1217		error = vfs_get_block_super(fc, gfs2_fill_super);
>    1218		if (error)
>    1219			return error;
>    1220	
>    1221		sdp = fc->root->d_sb->s_fs_info;
>    1222		dput(fc->root);
>    1223		if (args->ar_meta)
>    1224			fc->root = dget(sdp->sd_master_dir);
>    1225		else
>    1226			fc->root = dget(sdp->sd_root_dir);
>    1227		return 0;
>    1228	}
>    1229	
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
>