From: Andrew Price <anprice@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [GFS2 PATCH] gfs2: getlabel support
Date: Tue, 21 Aug 2018 10:03:11 +0100 [thread overview]
Message-ID: <d79c8724-3c72-534a-bd3c-aebf871d4968@redhat.com> (raw)
In-Reply-To: <1534821717-14902-1-git-send-email-adas@redhat.com>
On 21/08/18 04:21, Abhi Das wrote:
> Add support for the GETFSLABEL ioctl in gfs2.
> I tested this patch and it works as expected.
>
> Signed-off-by: Steve Whitehouse <swhiteho@redhat.com>
> Tested-by: Abhi Das <adas@redhat.com>
The message should probably start with a From: so that git am uses the
correct author. Looks good otherwise.
Cheers,
Andy
> ---
> fs/gfs2/file.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c
> index 08369c6..6510f4e 100644
> --- a/fs/gfs2/file.c
> +++ b/fs/gfs2/file.c
> @@ -314,6 +314,17 @@ static int gfs2_set_flags(struct file *filp, u32 __user *ptr)
> return do_gfs2_set_flags(filp, gfsflags, mask);
> }
>
> +static int gfs2_getlabel(struct file *filp, char __user *label)
> +{
> + struct inode *inode = file_inode(filp);
> + struct gfs2_sbd *sdp = GFS2_SB(inode);
> +
> + if (copy_to_user(label, sdp->sd_sb.sb_locktable, GFS2_LOCKNAME_LEN))
> + return -EFAULT;
> +
> + return 0;
> +}
> +
> static long gfs2_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
> {
> switch(cmd) {
> @@ -323,7 +334,10 @@ static long gfs2_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
> return gfs2_set_flags(filp, (u32 __user *)arg);
> case FITRIM:
> return gfs2_fitrim(filp, (void __user *)arg);
> + case FS_IOC_GETFSLABEL:
> + return gfs2_getlabel(filp, (char __user *)arg);
> }
> +
> return -ENOTTY;
> }
>
>
next prev parent reply other threads:[~2018-08-21 9:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 3:21 [Cluster-devel] [GFS2 PATCH] gfs2: getlabel support Abhi Das
2018-08-21 9:03 ` Andrew Price [this message]
2018-08-21 12:07 ` Bob Peterson
2018-10-08 20:07 ` Bob Peterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d79c8724-3c72-534a-bd3c-aebf871d4968@redhat.com \
--to=anprice@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).