cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: heming.zhao@suse.com <heming.zhao@suse.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [RFC PATCH dlm 00/10] dlm_controld config settings can be
Date: Tue, 21 Sep 2021 14:38:45 +0800	[thread overview]
Message-ID: <d8d58ce5-6a38-9b76-8b9c-8e52e8760681@suse.com> (raw)
In-Reply-To: <20210920175736.GA19901@redhat.com>

On 9/21/21 1:57 AM, David Teigland wrote:
> On Sun, Sep 19, 2021 at 02:43:12PM +0800, Heming Zhao wrote:
>> This new feature gives dlm ability to change config settings dynamically.
> 
> Hi Heming,
> 
> Letting dlm_controld reload certain settings from dlm.conf makes sense,
> but I'd like something more basic.  Let the user edit dlm.conf, then
> run dlm_tool reload_config to tell dlm_controld to reread dlm.conf, and
> apply new settings.  This doesn't involve remote nodes, it's all local.
> If the user wants, they can make changes on other nodes the same way.
> 
> (We don't need to touch the "run" extension, which I'd like to remove
> some day since it doesn't really belong in the dlm.)
> 

Hello Dave,

Thank you for your comment.

One of the reasons for my patch based on run command is user could send
command to all nodes by only one-line command.
Dynamic settings (my patch) requires user the least time/work to change
dlm_controld behaviors. If not, it needs to separately edit dlm.conf &
run reload cmd on every local node.

But I am ok with the reload_config idea, it's more basic.
We could give dlm_controld a chance to change behavior on the fly.
If needed, I could file a new patch for feature "reload_config", can I do it?

Heming



  reply	other threads:[~2021-09-21  6:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-19  6:43 [Cluster-devel] [RFC PATCH dlm 00/10] dlm_controld config settings can be Heming Zhao
2021-09-19  6:43 ` [Cluster-devel] [PATCH 01/10] dlm_tool man: add command "joinleave", add "USAGE" section Heming Zhao
2021-09-19  6:43 ` [Cluster-devel] [PATCH 02/10] dlm_tool: add run_(check|cancel) all feature Heming Zhao
2021-09-19  6:43 ` [Cluster-devel] [PATCH 03/10] dlm_tool man: add dynamic setting and examples Heming Zhao
2021-09-19  6:43 ` [Cluster-devel] [PATCH 04/10] dlm_controld: put MAX_LINE in header file Heming Zhao
2021-09-19  6:43 ` [Cluster-devel] [PATCH 05/10] dlm_controld: add dynamic setting items in "struct dlm_option" Heming Zhao
2021-09-19  6:43 ` [Cluster-devel] [PATCH 06/10] dlm_controld: change dlm_options[] to shared memory type Heming Zhao
2021-09-19  6:43 ` [Cluster-devel] [PATCH 07/10] dlm_controld: make few APIs public Heming Zhao
2021-09-19  6:43 ` [Cluster-devel] [PATCH 08/10] dlm_controld: support "dlm_tool dump_config" to show dynamic setting Heming Zhao
2021-09-19  6:43 ` [Cluster-devel] [PATCH 09/10] dlm_controld: add new API set_opt_online() Heming Zhao
2021-09-19  6:43 ` [Cluster-devel] [PATCH 10/10] dlm_controld: enable "dlm_tool run|run_start" dynamic setting feature Heming Zhao
2021-09-20 17:57 ` [Cluster-devel] [RFC PATCH dlm 00/10] dlm_controld config settings can be David Teigland
2021-09-21  6:38   ` heming.zhao [this message]
2021-09-21 13:54     ` David Teigland
2021-09-22  9:32       ` heming.zhao
2021-09-22 13:46         ` David Teigland
2021-09-22 14:35           ` heming.zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8d58ce5-6a38-9b76-8b9c-8e52e8760681@suse.com \
    --to=heming.zhao@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).