cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [RFC] MAINTAINERS tag for cleanup robot
Date: Sun, 22 Nov 2020 10:23:28 -0800	[thread overview]
Message-ID: <dec07021e7fc11a02b14c98b713ae2c6e2a4ca00.camel@perches.com> (raw)
In-Reply-To: <751803306cd957d0e7ef6a4fc3dbf12ebceaba92.camel@HansenPartnership.com>

On Sun, 2020-11-22 at 08:49 -0800, James Bottomley wrote:
> We can enforce sysfs_emit going forwards
> using tools like checkpatch

It's not really possible for checkpatch to find or warn about
sysfs uses of sprintf. checkpatch is really just a trivial
line-by-line parser and it has no concept of code intent.

It just can't warn on every use of the sprintf family.
There are just too many perfectly valid uses.

> but there's no benefit and a lot of harm to
> be done by trying to churn the entire tree

Single uses of sprintf for sysfs is not really any problem.

But likely there are still several possible overrun sprintf/snprintf
paths in sysfs.  Some of them are very obscure and unlikely to be
found by a robot as the logic for sysfs buf uses can be fairly twisty.

But provably correct conversions IMO _should_ be done and IMO churn
considerations should generally have less importance.





  reply	other threads:[~2020-11-22 18:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-21 16:50 [Cluster-devel] [RFC] MAINTAINERS tag for cleanup robot trix
2020-11-21 17:10 ` Joe Perches
2020-11-22 16:33   ` Tom Rix
2020-11-22 18:22     ` Joe Perches
2020-11-23 17:06       ` Tom Rix
2020-11-21 17:18 ` James Bottomley
2020-11-21 18:02   ` Joe Perches
2020-11-23 15:52   ` Jani Nikula
2020-11-23 16:17     ` Lukas Bulwahn
2020-11-22  3:23 ` Matthew Wilcox
2020-11-22 14:46   ` Tom Rix
2020-11-22 14:56     ` Matthew Wilcox
2020-11-22 16:10       ` Tom Rix
2020-11-22 16:49         ` James Bottomley
2020-11-22 18:23           ` Joe Perches [this message]
2020-11-22 22:33             ` Finn Thain
2020-11-23  0:53               ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dec07021e7fc11a02b14c98b713ae2c6e2a4ca00.camel@perches.com \
    --to=joe@perches.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).