From: joe@perches.com (Joe Perches)
To: cocci@systeme.lip6.fr
Subject: [Cocci] coccinelle and bitmask arithmetic
Date: Wed, 30 Jan 2013 00:29:23 -0800 [thread overview]
Message-ID: <1359534563.32305.6.camel@joe-AO722> (raw)
In-Reply-To: <5108D808.6010405@bfs.de>
On Wed, 2013-01-30 at 09:21 +0100, walter harms wrote:
> Am 29.01.2013 19:03, schrieb Joe Perches:
> > On Tue, 2013-01-29 at 18:49 +0100, Julia Lawall wrote:
> >> How about the following (from today's linux-next). They appear to be
> >> trying to do the same calculation, once with + and once with |.
> >
> > (cc'ing the original developer and Russell King)
> >
> > Likely the it8152_pci_platform_notify uses should use +
> >
> >> arch/arm/common/it8152.c
> >>
> >> int dma_set_coherent_mask(struct device *dev, u64 mask)
> >> {
> >> if (mask >= PHYS_OFFSET + SZ_64M - 1)
> >> return 0;
> >>
> >> return -EIO;
> >> }
> >>
>
> Great hit Joe :)
Julia and the others in the coccinelle group are the ones
with the whizzy program.
next prev parent reply other threads:[~2013-01-30 8:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130127194039.GA18787@elgon.mountain>
[not found] ` <1359317078.14406.12.camel@joe-AO722>
[not found] ` <20130127201947.GO16282@mwanda>
[not found] ` <9561.1359474916@turing-police.cc.vt.edu>
2013-01-29 16:13 ` [Cocci] coccinelle and bitmask arithmetic (was: Re: [patch] TTY: synclink, small cleanup in dtr_rts()) Joe Perches
2013-01-29 16:19 ` Julia Lawall
2013-01-29 16:31 ` Joe Perches
2013-01-29 17:30 ` Dan Carpenter
2013-01-29 17:42 ` Dan Carpenter
2013-01-29 17:49 ` Julia Lawall
2013-01-29 18:03 ` Joe Perches
2013-01-30 8:21 ` [Cocci] coccinelle and bitmask arithmetic walter harms
2013-01-30 8:29 ` Joe Perches [this message]
2013-01-30 11:14 ` Russell King - ARM Linux
2013-01-30 11:21 ` Julia Lawall
2013-01-30 11:35 ` Russell King - ARM Linux
2013-01-30 16:53 ` Joe Perches
2013-01-30 18:23 ` Russell King - ARM Linux
2013-01-29 18:38 ` [Cocci] coccinelle and bitmask arithmetic (was: Re: [patch] TTY: synclink, small cleanup in dtr_rts()) Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359534563.32305.6.camel@joe-AO722 \
--to=joe@perches.com \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox