From mboxrd@z Thu Jan 1 00:00:00 1970 From: mcgrof@do-not-panic.com (Luis R. Rodriguez) Date: Tue, 24 Jun 2014 15:39:41 -0700 Subject: [Cocci] [PATCH 1/3] mmc: vub300: use request_firmware_direct() for pseudo code In-Reply-To: <1403649583-12707-1-git-send-email-mcgrof@do-not-panic.com> References: <1403649583-12707-1-git-send-email-mcgrof@do-not-panic.com> Message-ID: <1403649583-12707-2-git-send-email-mcgrof@do-not-panic.com> To: cocci@systeme.lip6.fr List-Id: cocci@systeme.lip6.fr From: "Luis R. Rodriguez" vub300 uses the request_firmware() API for downloading pseudo code twice and if this fails its not considered fatal. Avoid letting the request linger 60 seconds because of udev if one of the requests fails by explicitly skipping the udev helper. This was found with the following SmPL patch. @ firmware_not_critical @ expression cf; expression config_file; expression dev; int ret; identifier l; statement S; @@ - ret = request_firmware(&cf, config_file, dev); + ret = request_firmware_direct(&cf, config_file, dev); if (ret < 0) { ... when != goto l; when != return ret; when any } else { ... release_firmware(cf); ... } Cc: Tony Olech Cc: linux-mmc at vger.kernel.org Cc: linux-usb at vger.kernel.org Cc: Takashi Iwai Cc: cocci at systeme.lip6.fr Signed-off-by: Luis R. Rodriguez --- drivers/mmc/host/vub300.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c index 4262296..15eeaff 100644 --- a/drivers/mmc/host/vub300.c +++ b/drivers/mmc/host/vub300.c @@ -1378,11 +1378,12 @@ static void download_offload_pseudocode(struct vub300_mmc_host *vub300) snprintf(vub300->vub_name + l, sizeof(vub300->vub_name) - l, ".bin"); dev_info(&vub300->udev->dev, "requesting offload firmware %s\n", vub300->vub_name); - retval = request_firmware(&fw, vub300->vub_name, &card->dev); + retval = request_firmware_direct(&fw, vub300->vub_name, &card->dev); if (retval < 0) { strncpy(vub300->vub_name, "vub_default.bin", sizeof(vub300->vub_name)); - retval = request_firmware(&fw, vub300->vub_name, &card->dev); + retval = request_firmware_direct(&fw, vub300->vub_name, + &card->dev); if (retval < 0) { strncpy(vub300->vub_name, "no SDIO offload firmware found", -- 2.0.0