From: joe@perches.com (Joe Perches)
To: cocci@systeme.lip6.fr
Subject: [Cocci] coccinelle: bool if (foo) return true; else return false;
Date: Tue, 19 Apr 2016 12:12:32 -0700 [thread overview]
Message-ID: <1461093152.1917.26.camel@perches.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1604172001410.2004@localhost6.localdomain6>
There's ~150 of these in the kernel.
Maybe there's use for this conversion to be added
to?scripts/coccinelle/misc/boolreturn.cocci or in
a separate file.
$ cat booltruefalse.cocci
@@
identifier fn;
expression e;
typedef bool;
symbol true;
symbol false;
@@
bool fn ( ... )
{
<...
- if (e) return true; else return false;
+ return e;
...>
}
@@
identifier fn;
expression e;
@@
bool fn ( ... )
{
<...
- if (e) return false; else return true;
+ return !e;
...>
}
next parent reply other threads:[~2016-04-19 19:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1460828078-5224-1-git-send-email-dave@stgolabs.net>
[not found] ` <1460833453.19090.79.camel@perches.com>
[not found] ` <1460836099.19090.82.camel@perches.com>
[not found] ` <alpine.DEB.2.02.1604170743060.2068@localhost6.localdomain6>
[not found] ` <1460881671.19090.90.camel@perches.com>
[not found] ` <alpine.DEB.2.02.1604171337450.2034@localhost6.localdomain6>
[not found] ` <1460908959.19090.95.camel@perches.com>
[not found] ` <alpine.DEB.2.02.1604171944500.2004@localhost6.localdomain6>
[not found] ` <1460915801.19090.100.camel@perches.com>
[not found] ` <alpine.DEB.2.02.1604172001410.2004@localhost6.localdomain6>
2016-04-19 19:12 ` Joe Perches [this message]
2016-04-19 19:15 ` [Cocci] coccinelle: bool if (foo) return true; else return false; Julia Lawall
2016-04-20 7:19 ` Michael Stefaniuc
2016-04-20 7:25 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461093152.1917.26.camel@perches.com \
--to=joe@perches.com \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox