From: johannes@sipsolutions.net (Johannes Berg)
To: cocci@systeme.lip6.fr
Subject: [Cocci] position confusion?
Date: Sat, 28 Jan 2017 09:18:08 +0100 [thread overview]
Message-ID: <1485591488.4812.2.camel@sipsolutions.net> (raw)
In-Reply-To: <9d692cfd-f6a0-fef4-bcbb-84564e60beb5@oracle.com>
On Sat, 2017-01-28 at 12:10 +0530, Vaishali Thakkar wrote:
> On Saturday 28 January 2017 04:40 AM, Johannes Berg wrote:
> > This is nonsense, but I don't see why it shouldn't parse:
>
> Hi,
>
> > @a@
> > type T;
> > identifier x;
> > position p;
> > @@
> > T x at p = { };
> >
> > @b@
> > type T;
> > identifier x;
> > position p;
>
> This should be "position p != a.p;".
That has no effect on the point I was trying to make. I told you the
spatch was nonsense ... :)
> > @@
> > T x at p = { };
> >
> > @@
> > position p != a.p;
> > position q != b.p;
>
> And here no need to put constraint for q.
There was no need to put a constraint anyway, again, the whole patch
made no sense. But assume I wanted to have p and q in different
positions, or whatever. Note that I didn't even *use* @p in the rule,
so you're making wrong assumptions.
> position p != {a.p, b.p};
Nevertheless, that's something I learned.
johannes
next prev parent reply other threads:[~2017-01-28 8:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 23:10 [Cocci] position confusion? Johannes Berg
2017-01-28 6:37 ` Julia Lawall
2017-01-28 6:40 ` Vaishali Thakkar
2017-01-28 8:18 ` Johannes Berg [this message]
2017-01-28 9:11 ` Vaishali Thakkar
2017-01-28 9:16 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485591488.4812.2.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox