Coccinelle Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sebastian@breakpoint.cc (Sebastian Andrzej Siewior)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances
Date: Thu, 12 Mar 2015 18:20:07 +0100	[thread overview]
Message-ID: <20150312172006.GA18418@breakpoint.cc> (raw)
In-Reply-To: <54E3BA20.3080205@codeaurora.org>

On 2015-02-17 14:01:04 [-0800], Stephen Boyd wrote:
> diff = 
> --- arch/arm/mach-imx/mach-imx6q.c
> +++ /tmp/cocci-output-11792-b62223-mach-imx6q.c
> @@ -211,7 +211,6 @@ static void __init imx6q_1588_init(void)
>  	 * set bit IOMUXC_GPR1[21].  Or the PTP clock must be from pad
>  	 * (external OSC), and we need to clear the bit.
>  	 */
> -	clksel = ptp_clk == enet_ref ? IMX6Q_GPR1_ENET_CLK_SEL_ANATOP :
>  				       IMX6Q_GPR1_ENET_CLK_SEL_PAD;
>  	gpr = syscon_regmap_lookup_by_compatible("fsl,imx6q-iomuxc-gpr");
>  	if (!IS_ERR(gpr))

Any idea how to do the comparison here? Or should we rely that the bootloader
sets this properly (it managed already to select a frequency)? The phy has no
clock node in current DT's so we can check this.

Sebastian

  reply	other threads:[~2015-03-12 17:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1422011024-32283-1-git-send-email-tomeu.vizoso@collabora.com>
     [not found] ` <1422011024-32283-4-git-send-email-tomeu.vizoso@collabora.com>
     [not found]   ` <20150201212432.22722.70917@quantum>
2015-02-02 20:45     ` [Cocci] [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances Stephen Boyd
2015-02-02 21:31       ` Julia Lawall
2015-02-02 22:35         ` Stephen Boyd
2015-02-02 22:50           ` Mike Turquette
2015-02-03 16:04             ` Quentin Lambert
2015-02-04 23:26               ` Stephen Boyd
2015-02-05 15:45                 ` Quentin Lambert
2015-02-05 16:02                   ` Quentin Lambert
2015-02-06  1:49                     ` Stephen Boyd
2015-02-06  2:15                   ` Stephen Boyd
2015-02-06  9:01                     ` Quentin Lambert
2015-02-06  9:12                       ` Julia Lawall
2015-02-06 17:15                         ` Stephen Boyd
2015-02-17 22:01                     ` Stephen Boyd
2015-03-12 17:20                       ` Sebastian Andrzej Siewior [this message]
2015-03-12 19:43                         ` Stephen Boyd
2015-03-13  3:29                           ` Shawn Guo
2015-03-13  8:20                             ` Sebastian Andrzej Siewior
2015-03-13 13:42                               ` Shawn Guo
2015-03-13 17:42                             ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150312172006.GA18418@breakpoint.cc \
    --to=sebastian@breakpoint.cc \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox