* Re: [cocci] [PATCH net-next 1/5] net: rpmsg-eth: Add Documentation for RPMSG-ETH Driver
2025-07-23 13:49 ` [cocci] [PATCH net-next 1/5] net: rpmsg-eth: Add Documentation for RPMSG-ETH Driver Jakub Kicinski
@ 2025-07-24 6:54 ` MD Danish Anwar
2025-08-04 12:10 ` Julia Lawall
2025-08-04 16:45 ` Julia Lawall
2 siblings, 0 replies; 5+ messages in thread
From: MD Danish Anwar @ 2025-07-24 6:54 UTC (permalink / raw)
To: Jakub Kicinski, Julia Lawall
Cc: David S. Miller, Eric Dumazet, Paolo Abeni, Simon Horman,
Jonathan Corbet, Andrew Lunn, Mengyuan Lou, Michael Ellerman,
Madhavan Srinivasan, Fan Gong, Lee Trager, Lorenzo Bianconi,
Geert Uytterhoeven, Lukas Bulwahn, Parthiban Veerasooran, netdev,
linux-doc, linux-kernel, cocci, Nicolas Palix
Hi Jakub,
On 23/07/25 7:19 pm, Jakub Kicinski wrote:
> On Wed, 23 Jul 2025 13:33:18 +0530 MD Danish Anwar wrote:
>> + - Vendors must ensure the magic number matches the value expected by the
>> + Linux driver (see the `RPMSG_ETH_SHM_MAGIC_NUM` macro in the driver
>> + source).
>
> For some reason this trips up make coccicheck:
>
> EXN: Failure("unexpected paren order") in /home/cocci/testing/Documentation/networking/device_drivers/ethernet/rpmsg_eth.rst
>
> If I replace the brackets with a comma it works:
>
> - Vendors must ensure the magic number matches the value expected by the
> Linux driver, see the `RPMSG_ETH_SHM_MAGIC_NUM` macro in the driver
> source.
>
> Could you make that change in the next revision to avoid the problem?
>
Sure. I'll do this change in v2.
> Julia, is there an easy way to make coccinelle ignore files which
> don't end with .c or .h when using --use-patch-diff ?
--
Thanks and Regards,
Danish
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [cocci] [PATCH net-next 1/5] net: rpmsg-eth: Add Documentation for RPMSG-ETH Driver
2025-07-23 13:49 ` [cocci] [PATCH net-next 1/5] net: rpmsg-eth: Add Documentation for RPMSG-ETH Driver Jakub Kicinski
2025-07-24 6:54 ` MD Danish Anwar
@ 2025-08-04 12:10 ` Julia Lawall
2025-08-04 16:45 ` Julia Lawall
2 siblings, 0 replies; 5+ messages in thread
From: Julia Lawall @ 2025-08-04 12:10 UTC (permalink / raw)
To: Jakub Kicinski
Cc: MD Danish Anwar, David S. Miller, Eric Dumazet, Paolo Abeni,
Simon Horman, Jonathan Corbet, Andrew Lunn, Mengyuan Lou,
Michael Ellerman, Madhavan Srinivasan, Fan Gong, Lee Trager,
Lorenzo Bianconi, Geert Uytterhoeven, Lukas Bulwahn,
Parthiban Veerasooran, netdev, linux-doc, linux-kernel, cocci,
Nicolas Palix
On Wed, 23 Jul 2025, Jakub Kicinski wrote:
> On Wed, 23 Jul 2025 13:33:18 +0530 MD Danish Anwar wrote:
> > + - Vendors must ensure the magic number matches the value expected by the
> > + Linux driver (see the `RPMSG_ETH_SHM_MAGIC_NUM` macro in the driver
> > + source).
>
> For some reason this trips up make coccicheck:
>
> EXN: Failure("unexpected paren order") in /home/cocci/testing/Documentation/networking/device_drivers/ethernet/rpmsg_eth.rst
>
> If I replace the brackets with a comma it works:
>
> - Vendors must ensure the magic number matches the value expected by the
> Linux driver, see the `RPMSG_ETH_SHM_MAGIC_NUM` macro in the driver
> source.
>
> Could you make that change in the next revision to avoid the problem?
>
> Julia, is there an easy way to make coccinelle ignore files which
> don't end with .c or .h when using --use-patch-diff ?
Perhaps not. I can adjust it.
julia
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [cocci] [PATCH net-next 1/5] net: rpmsg-eth: Add Documentation for RPMSG-ETH Driver
2025-07-23 13:49 ` [cocci] [PATCH net-next 1/5] net: rpmsg-eth: Add Documentation for RPMSG-ETH Driver Jakub Kicinski
2025-07-24 6:54 ` MD Danish Anwar
2025-08-04 12:10 ` Julia Lawall
@ 2025-08-04 16:45 ` Julia Lawall
2025-08-04 23:47 ` Jakub Kicinski
2 siblings, 1 reply; 5+ messages in thread
From: Julia Lawall @ 2025-08-04 16:45 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: cocci, Nicolas Palix
On Wed, 23 Jul 2025, Jakub Kicinski wrote:
> On Wed, 23 Jul 2025 13:33:18 +0530 MD Danish Anwar wrote:
> > + - Vendors must ensure the magic number matches the value expected by the
> > + Linux driver (see the `RPMSG_ETH_SHM_MAGIC_NUM` macro in the driver
> > + source).
>
> For some reason this trips up make coccicheck:
>
> EXN: Failure("unexpected paren order") in /home/cocci/testing/Documentation/networking/device_drivers/ethernet/rpmsg_eth.rst
>
> If I replace the brackets with a comma it works:
>
> - Vendors must ensure the magic number matches the value expected by the
> Linux driver, see the `RPMSG_ETH_SHM_MAGIC_NUM` macro in the driver
> source.
>
> Could you make that change in the next revision to avoid the problem?
>
> Julia, is there an easy way to make coccinelle ignore files which
> don't end with .c or .h when using --use-patch-diff ?
This will be the default shortly.
julia
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [cocci] [PATCH net-next 1/5] net: rpmsg-eth: Add Documentation for RPMSG-ETH Driver
2025-08-04 16:45 ` Julia Lawall
@ 2025-08-04 23:47 ` Jakub Kicinski
0 siblings, 0 replies; 5+ messages in thread
From: Jakub Kicinski @ 2025-08-04 23:47 UTC (permalink / raw)
To: Julia Lawall; +Cc: cocci, Nicolas Palix
On Mon, 4 Aug 2025 18:45:50 +0200 (CEST) Julia Lawall wrote:
> > EXN: Failure("unexpected paren order") in /home/cocci/testing/Documentation/networking/device_drivers/ethernet/rpmsg_eth.rst
> >
> > If I replace the brackets with a comma it works:
> >
> > - Vendors must ensure the magic number matches the value expected by the
> > Linux driver, see the `RPMSG_ETH_SHM_MAGIC_NUM` macro in the driver
> > source.
> >
> > Could you make that change in the next revision to avoid the problem?
> >
> > Julia, is there an easy way to make coccinelle ignore files which
> > don't end with .c or .h when using --use-patch-diff ?
>
> This will be the default shortly.
Perfect, thank you!
^ permalink raw reply [flat|nested] 5+ messages in thread