From: Ping-Ke Shih <pkshih@realtek.com>
To: Sang-Heon Jeon <ekffu200098@gmail.com>,
"Julia.Lawall@inria.fr" <Julia.Lawall@inria.fr>,
Miri Korenblit <miriam.rachel.korenblit@intel.com>
Cc: "cocci@inria.fr" <cocci@inria.fr>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [cocci] [PATCH 10/36] wifi: remove conditional return with no effect
Date: Fri, 24 Jul 2026 00:37:29 +0000 [thread overview]
Message-ID: <3c36ea4acf0545a28f8c64dd49539cc6@realtek.com> (raw)
In-Reply-To: <20260723184538.3888637-11-ekffu200098@gmail.com>
Sang-Heon Jeon <ekffu200098@gmail.com> wrote:
> Both branches of the check return the same value, so the check has
> no effect. Remove it and return the value directly.
>
> This is the result of running the Coccinelle script from
> scripts/coccinelle/misc/cond_return_no_effect.cocci.
>
> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
> ---
> drivers/net/wireless/ath/ath6kl/init.c | 6 +-----
> drivers/net/wireless/intel/iwlwifi/mvm/link.c | 6 +-----
> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 7 +------
> drivers/net/wireless/realtek/rtw89/mac.c | 6 +-----
> drivers/net/wireless/realtek/rtw89/mac_be.c | 6 +-----
Can you split into four patches for ath6k, iwlwifi, rtlwifi and rtw89?
Then we can apply the patch to individual tree.
Ping-Ke
next prev parent reply other threads:[~2026-07-24 8:55 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 18:45 [cocci] [PATCH 00/36] treewide: remove conditional returns with no effect Sang-Heon Jeon
2026-07-23 18:45 ` [cocci] [PATCH 01/36] coccinelle: misc: add cond_return_no_effect.cocci Sang-Heon Jeon
2026-07-24 14:41 ` Sang-Heon Jeon
2026-07-24 14:55 ` Julia Lawall
2026-07-24 16:48 ` Sang-Heon Jeon
[not found] ` <077ae2e1-c471-4e87-9d40-caddd3a8a358@web.de>
2026-07-26 11:54 ` [cocci] [1/36] " Julia Lawall
[not found] ` <b0577cf2-d8eb-473f-87af-82ecc653f29c@web.de>
2026-07-24 11:38 ` [cocci] [PATCH 01/36] " Julia Lawall
2026-07-24 14:42 ` Sang-Heon Jeon
[not found] ` <73b974fc-971b-41bd-a039-7566442ccc63@web.de>
2026-07-24 16:33 ` [cocci] [1/36] " Sang-Heon Jeon
2026-07-23 18:45 ` [cocci] [PATCH 02/36] drm/amd: remove conditional return with no effect Sang-Heon Jeon
2026-07-23 18:45 ` [cocci] [PATCH 03/36] drm/radeon: " Sang-Heon Jeon
2026-07-23 18:45 ` [cocci] [PATCH 04/36] dpll: zl3073x: " Sang-Heon Jeon
2026-07-23 18:45 ` [cocci] [PATCH 05/36] drm/i915: " Sang-Heon Jeon
2026-07-23 18:45 ` [cocci] [PATCH 06/36] drm: " Sang-Heon Jeon
2026-07-23 18:45 ` [cocci] [PATCH 07/36] net: ethernet: " Sang-Heon Jeon
2026-07-23 20:24 ` Niklas Söderlund
2026-07-23 20:35 ` Kiyanovski, Arthur
2026-07-23 18:45 ` [cocci] [PATCH 08/36] net: " Sang-Heon Jeon
2026-07-23 19:04 ` Andrew Lunn
2026-07-23 18:45 ` [cocci] [PATCH 09/36] net: intel: " Sang-Heon Jeon
2026-07-23 18:45 ` [cocci] [PATCH 10/36] wifi: " Sang-Heon Jeon
2026-07-24 0:37 ` Ping-Ke Shih [this message]
2026-07-23 18:45 ` [cocci] [PATCH 11/36] ipvs: " Sang-Heon Jeon
2026-07-23 18:45 ` [cocci] [PATCH 12/36] media: " Sang-Heon Jeon
2026-07-23 20:26 ` Niklas Söderlund
2026-08-07 7:52 ` Eugen Hristev
2026-08-07 12:28 ` Laurent Pinchart
2026-08-10 9:41 ` Sakari Ailus
2026-07-23 18:45 ` [cocci] [PATCH 13/36] ALSA: " Sang-Heon Jeon
2026-07-23 18:45 ` [cocci] [PATCH 14/36] ASoC: " Sang-Heon Jeon
2026-07-24 5:05 ` Mukunda,Vijendar
2026-07-23 18:45 ` [cocci] [PATCH 15/36] iio: " Sang-Heon Jeon
2026-07-23 21:46 ` Joshua Crofts
2026-07-24 0:38 ` Jonathan Cameron
2026-07-24 15:22 ` Sang-Heon Jeon
2026-07-23 18:45 ` [cocci] [PATCH 16/36] Input: " Sang-Heon Jeon
2026-07-23 18:45 ` [cocci] [PATCH 17/36] clk: " Sang-Heon Jeon
2026-07-23 18:45 ` [cocci] [PATCH 18/36] crypto: drivers - " Sang-Heon Jeon
2026-07-23 18:45 ` [cocci] [PATCH 19/36] dmaengine: qcom_hidma: " Sang-Heon Jeon
2026-07-23 18:45 ` [cocci] [PATCH 20/36] stm class: " Sang-Heon Jeon
2026-07-23 18:45 ` [cocci] [PATCH 21/36] RDMA/ocrdma: " Sang-Heon Jeon
2026-07-23 18:45 ` [cocci] [PATCH 22/36] iommu/s390: " Sang-Heon Jeon
2026-07-23 18:45 ` [cocci] [PATCH 23/36] dm vdo: " Sang-Heon Jeon
2026-07-23 18:45 ` [cocci] [PATCH 24/36] pinctrl: mediatek: " Sang-Heon Jeon
2026-07-23 18:45 ` [cocci] [PATCH 25/36] platform/x86: toshiba_haps: " Sang-Heon Jeon
[not found] ` <339532bc-e6e1-4b40-af18-49153c25ad64@linux.intel.com>
2026-07-24 16:21 ` Sang-Heon Jeon
2026-07-23 18:45 ` [cocci] [PATCH 26/36] power: supply: pm8916_lbc: " Sang-Heon Jeon
2026-07-23 18:45 ` [cocci] [PATCH 27/36] RAS/AMD/ATL: " Sang-Heon Jeon
2026-07-23 19:44 ` Borislav Petkov
2026-07-23 18:45 ` [cocci] [PATCH 28/36] regulator: wm831x-isink: " Sang-Heon Jeon
2026-07-24 8:24 ` Charles Keepax
2026-07-23 18:45 ` [cocci] [PATCH 29/36] rtc: pcf2127: " Sang-Heon Jeon
2026-08-20 21:28 ` [cocci] (subset) " Alexandre Belloni
2026-07-23 18:45 ` [cocci] [PATCH 30/36] scsi: mpt3sas: " Sang-Heon Jeon
2026-07-23 18:45 ` [cocci] [PATCH 31/36] thermal/drivers/k3_bandgap: " Sang-Heon Jeon
2026-07-23 18:45 ` [cocci] [PATCH 32/36] USB: serial: ch341: " Sang-Heon Jeon
2026-07-23 18:45 ` [cocci] [PATCH 33/36] usb: typec: fusb302: " Sang-Heon Jeon
2026-07-23 18:45 ` [cocci] [PATCH 34/36] smb: client: " Sang-Heon Jeon
2026-07-23 20:27 ` Steve French
2026-07-24 17:12 ` Sang-Heon Jeon
2026-07-23 18:45 ` [cocci] [PATCH 35/36] cpupower: " Sang-Heon Jeon
2026-08-04 19:15 ` Shuah
2026-07-23 18:45 ` [cocci] [PATCH 36/36] memblock: " Sang-Heon Jeon
2026-08-06 19:06 ` [cocci] (subset) [PATCH 00/36] treewide: remove conditional returns " Martin K. Petersen
2026-08-11 18:51 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c36ea4acf0545a28f8c64dd49539cc6@realtek.com \
--to=pkshih@realtek.com \
--cc=Julia.Lawall@inria.fr \
--cc=cocci@inria.fr \
--cc=ekffu200098@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox